Reset crash loop counter some time after starting

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: JanH, Assigned: JanH)

Tracking

Trunk
Firefox 55
All
Android
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
At the moment our crash loop counter that turns off session restoring is reset only after successful background-foreground cycle.

Since its purpose is to break out of start up crash loops caused by the currently loaded tab, it makes sense to also (or instead?) reset it if we didn't crash within the first minute or so after starting up.
(Assignee)

Updated

2 years ago
See Also: → bug 1362328
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8866453 [details]
Bug 1363321 - Part 1 - Always copy crash restore settings to Java on startup.

https://reviewboard.mozilla.org/r/138078/#review141296
Attachment #8866453 - Flags: review?(nchen) → review+

Comment 4

2 years ago
mozreview-review
Comment on attachment 8866454 [details]
Bug 1363321 - Part 2 - Reset crash loop counter after a presumably succesful startup.

https://reviewboard.mozilla.org/r/138080/#review141306

::: mobile/android/base/java/org/mozilla/gecko/GeckoApp.java:188
(Diff revision 1)
>      // after a version upgrade.
>      private static final int CLEANUP_DEFERRAL_SECONDS = 15;
>  
> +    // Length of time in ms during which crashes are classified as startup crashes
> +    // for crash loop detection purposes.
> +    private static final int STARTUP_PHASE_DURATION = 30 * 1000;

Maybe `STARTUP_PHASE_DURATION_MILLIS` to match other time constants that have units at the end.
Attachment #8866454 - Flags: review?(nchen) → review+
Comment hidden (mozreview-request)

Comment 6

2 years ago
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/5ce60a1ee7c9
Part 1 - Always copy crash restore settings to Java on startup. r=jchen
https://hg.mozilla.org/integration/autoland/rev/5c918b5507a6
Part 2 - Reset crash loop counter after a presumably succesful startup. r=jchen
https://hg.mozilla.org/mozilla-central/rev/5ce60a1ee7c9
https://hg.mozilla.org/mozilla-central/rev/5c918b5507a6
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.