Closed Bug 1363333 Opened 7 years ago Closed 7 years ago

Use the same Python binaries in Vagrant as Heroku

Categories

(Tree Management :: Treeherder, enhancement, P2)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file)

There are a few issues at the moment:
1) Heroku is using Python 2.7.13, whereas vagrant is on 2.7.12.
2) The Vagrant Python cannot be updated to a newer version since it's using the fkrull/deadsnakes PPA which is no longer maintained.
3) The Python build-time options have in the past varied between the two Python distributions.
4) The Vagrant Python version isn't pinned so doesn't stay in sync with that in runtimes.txt.
5) The Vagrant provision makes use of virtualenv, when that doesn't match the Heroku setup at all.

We can fix all of the above by doing what the Python Heroku buildpack does in Vagrant. ie: use runtimes.txt to find the desired version and then download the built version from Heroku's Python S3 bucket.

This will also simplify the transition to Ubuntu 16.04 and/or a docker based development solution.
Attachment #8865829 - Flags: review?(cdawson)
Attachment #8865829 - Flags: review?(cdawson) → review+
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/f9d1f89a9b4594efee6a145290e6fba87f913355
Bug 1363333 - Vagrant: Set PATH instead of activating virtualenv

Adds the virtualenv directory to `PATH` in `env.sh`, to save having
to activate the virtualenv (which is about to be removed) or set
`PATH` in each of the wrapper bin scripts.

https://github.com/mozilla/treeherder/commit/d604044192c2a5dd188b55df2ebe5cf99a31299d
Bug 1363333 - Vagrant: Switch from Python PPA to Heroku binaries

Since the third-party PPA is no longer maintained, and doesn't have
Python 2.7.13 which is what is being used on Heroku. Instead we copy
the Heroku Python buildpack installation method for greater parity:
https://github.com/heroku/heroku-buildpack-python/blob/18c404f72d655912747568d3fa6613b1da39effd/bin/steps/python

https://github.com/mozilla/treeherder/commit/1e9113c6516bb38eb20f6301ed11445323271c33
Bug 1363333 - Vagrant/Travis: Update pip to 9.0.1

https://pip.pypa.io/en/stable/news/
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Blocks: 1363444
Component: Treeherder: Docs & Development → TreeHerder
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: