1363336 - [Static Analysis][Dereference before null check] In function nsSocketTransport::InitiateSocket

Status: RESOLVED FIXED

(Core :: Networking, enhancement)

Description

[Andi [:andi]]

The Static Analysis tool Coverity detected that |fd| can produce a null pointer dereference since it's already dereferenced before being null checked:

[1] Null check
>>    if (fd && mFastOpenCallback &&
>>        mFastOpenCallback->FastOpenEnabled()) {

[2] Dereference
>>   status = PR_SetSocketOption(fd, &opt);

[3] Allocation
>>    PRFileDesc *fd;
>>    bool proxyTransparent;
>>    bool usingSSL;
>>
>>    rv = BuildSocket(fd, proxyTransparent, usingSSL);
>>    if (NS_FAILED(rv)) {
>>        SOCKET_LOG(("  BuildSocket failed [rv=%" PRIx32 "]\n", static_cast<uint32_t>(rv)));
>>        return rv;
>>    }

Looking at [3] the null check is useless and causes a false-positive, we should eliminate it.

Comment 1

[Andi [:andi]]

Attachment: Bug 1363336 - eliminate useless null-check in for |fd|.

Review commit: https://reviewboard.mozilla.org/r/137430/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137430/

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8865827 [details]
Bug 1363336 - eliminate useless null-check in for |fd|.

https://reviewboard.mozilla.org/r/137430/#review140574

Please remove whitespace-only changes from the patch.
The review should probably be done by :dragana since she wrote this code.
Thanks!

Comment 3

[Andi [:andi]]

Comment on attachment 8865827 [details]
Bug 1363336 - eliminate useless null-check in for |fd|.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/137430/diff/1-2/

Comment 4

[Dragana Damjanovic [:dragana]]

Comment on attachment 8865827 [details]
Bug 1363336 - eliminate useless null-check in for |fd|.

https://reviewboard.mozilla.org/r/137430/#review140584

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4bbf624389f1
eliminate useless null-check in for |fd|. r=dragana

Comment 6

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/4bbf624389f1