1363353 - Make mobile/android ESLint rules inherit from the mozilla/recommended configuration

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Mark Banner (:standard8)]

I'm preparing to get the general ESLint rules we have in the eslint-plugin-mozilla recommended configuration spread around the tree more widely (bug 1359011).

This serves several aims: that we can reduce duplicate definitions, have a clearer picture of differences in the tree, and make it easier to find places where we need improvements - e.g. getting more rules enabled/fixed.

I currently have a few patches in progress to do this for mobile/android/

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1363353 - Rename the .eslintrc files for mobile to .eslintrc.js to match the rest of the tree.

Review commit: https://reviewboard.mozilla.org/r/137436/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137436/

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1363353 - Apply mozilla/recommended ESLint rules to mobile/android.

Review commit: https://reviewboard.mozilla.org/r/137438/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137438/

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8865834 [details]
Bug 1363353 - Rename the .eslintrc files for mobile to .eslintrc.js to match the rest of the tree.

https://reviewboard.mozilla.org/r/137436/#review140604

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8865835 [details]
Bug 1363353 - Apply mozilla/recommended ESLint rules to mobile/android.

https://reviewboard.mozilla.org/r/137438/#review140606

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5cfae1cc920
Rename the .eslintrc files for mobile to .eslintrc.js to match the rest of the tree. r=sebastian
https://hg.mozilla.org/integration/autoland/rev/e3983f525a1f
Apply mozilla/recommended ESLint rules to mobile/android. r=sebastian

Comment 6

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/b5cfae1cc920
https://hg.mozilla.org/mozilla-central/rev/e3983f525a1f