Closed Bug 1363353 Opened 7 years ago Closed 7 years ago

Make mobile/android ESLint rules inherit from the mozilla/recommended configuration

Categories

(Firefox for Android Graveyard :: General, enhancement)

Product:
Firefox for Android Graveyard
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox55 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(2 files)

Bug 1363353 - Rename the .eslintrc files for mobile to .eslintrc.js to match the rest of the tree.
59 bytes, text/x-review-board-request
sebastian
: review+
Details
Bug 1363353 - Apply mozilla/recommended ESLint rules to mobile/android.
59 bytes, text/x-review-board-request
sebastian
: review+
Details 
I'm preparing to get the general ESLint rules we have in the eslint-plugin-mozilla recommended configuration spread around the tree more widely (bug 1359011).

This serves several aims: that we can reduce duplicate definitions, have a clearer picture of differences in the tree, and make it easier to find places where we need improvements - e.g. getting more rules enabled/fixed.

I currently have a few patches in progress to do this for mobile/android/
Comment on attachment 8865834 [details]
Bug 1363353 - Rename the .eslintrc files for mobile to .eslintrc.js to match the rest of the tree.

https://reviewboard.mozilla.org/r/137436/#review140604
Attachment #8865834 - Flags: review?(s.kaspari) → review+
Comment on attachment 8865835 [details]
Bug 1363353 - Apply mozilla/recommended ESLint rules to mobile/android.

https://reviewboard.mozilla.org/r/137438/#review140606
Attachment #8865835 - Flags: review?(s.kaspari) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b5cfae1cc920
Rename the .eslintrc files for mobile to .eslintrc.js to match the rest of the tree. r=sebastian
https://hg.mozilla.org/integration/autoland/rev/e3983f525a1f
Apply mozilla/recommended ESLint rules to mobile/android. r=sebastian
https://hg.mozilla.org/mozilla-central/rev/b5cfae1cc920
https://hg.mozilla.org/mozilla-central/rev/e3983f525a1f
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.