Closed Bug 1363353 Opened 4 years ago Closed 4 years ago

Make mobile/android ESLint rules inherit from the mozilla/recommended configuration

Categories

(Firefox for Android Graveyard :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(2 files)

I'm preparing to get the general ESLint rules we have in the eslint-plugin-mozilla recommended configuration spread around the tree more widely (bug 1359011).

This serves several aims: that we can reduce duplicate definitions, have a clearer picture of differences in the tree, and make it easier to find places where we need improvements - e.g. getting more rules enabled/fixed.

I currently have a few patches in progress to do this for mobile/android/
Comment on attachment 8865834 [details]
Bug 1363353 - Rename the .eslintrc files for mobile to .eslintrc.js to match the rest of the tree.

https://reviewboard.mozilla.org/r/137436/#review140604
Attachment #8865834 - Flags: review?(s.kaspari) → review+
Comment on attachment 8865835 [details]
Bug 1363353 - Apply mozilla/recommended ESLint rules to mobile/android.

https://reviewboard.mozilla.org/r/137438/#review140606
Attachment #8865835 - Flags: review?(s.kaspari) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b5cfae1cc920
Rename the .eslintrc files for mobile to .eslintrc.js to match the rest of the tree. r=sebastian
https://hg.mozilla.org/integration/autoland/rev/e3983f525a1f
Apply mozilla/recommended ESLint rules to mobile/android. r=sebastian
https://hg.mozilla.org/mozilla-central/rev/b5cfae1cc920
https://hg.mozilla.org/mozilla-central/rev/e3983f525a1f
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.