1363406 - Regression: "Show your bookmarks" button shrinks in size if moved to the Bookmarks Toolbar

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Itiel]

Attachment: Shrinking button

Tested environment:
Windows 10 build 1607

STR:
1. Install latest Nightly
2. Enable the Bookmarks Toolbar
3. Move the "Show your bookmarks" button to the Bookmarks Toolbar

AR:
The "Show your bookmarks" button shrinks in size (the "Bookmark this page" button remains unchanged). See attached.

ER:
It shouldn't.

This bug doesn't seem to affect any other built-in Firefox buttons.

Regression range:
Good: 2.5.17
Bad: 3.5.17

Mozregression narrows it down to:
2017-05-09T17:48:09: DEBUG : Using url: https://hg.mozilla.org/mozilla-central/json-pushes?changeset=a748acbebbde373a88868dc02910fb2bc5e6a023&full=1
2017-05-09T17:48:10: DEBUG : Found commit message:
Backed out changeset d3197ffef609 (bug 1338217) for failures in test_webassembly_compile.html on at least Windows VM debug a=backout a=merge

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Maybe a dupe? Dao was following a similar regression recently.

Comment 2

[Dão Gottwald [:dao]]

(In reply to ItielMaN from comment #0)
> Mozregression narrows it down to:
> 2017-05-09T17:48:09: DEBUG : Using url:
> https://hg.mozilla.org/mozilla-central/json-pushes?changeset=a748acbebbde373a88868dc02910fb2bc5e6a023&full=1

Likely a regression from bug 1352364.

Comment 3

[Johann Hofmann [:johannh]]

Yup, sorry, my fault. Taking.

Comment 4

[Johann Hofmann [:johannh]]

Attachment: Bug 1363406 - Only apply padding to the bookmark menu button in the nav bar.

This patch reverts a change that bug 1352364 accidentally introduced
that led to the bookmark menu button shrinking in the bookmarks toolbar.

Review commit: https://reviewboard.mozilla.org/r/137620/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137620/

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 8866028 [details]
Bug 1363406 - Only apply padding to the bookmark menu button in the nav bar.

https://reviewboard.mozilla.org/r/137620/#review140736

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b818cfd054a6
Only apply padding to the bookmark menu button in the nav bar. r=dao

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b818cfd054a6

Comment 9

[Itiel]

Confirmed fixed on latest Nightly.
Marking as VERIFIED FIXED.

Comment 10

[ovidiu boca[:Ovidiu]]

I tested this issue using FF Nightly 56.0a1(2017-06-13) and I can confirm the fix.