1363420 - enable Talos for |linux64-stylo-sequential opt|

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Kim Moir [:kmoir] ET]

From https://bugzilla.mozilla.org/show_bug.cgi?id=1355023#c6

Ok, looks like the only thing left to do here is to enable Talos for |linux64-stylo-sequential opt|. Kim, can you take care of this? Much appreciate all the help here.

Comment 1

[Kim Moir [:kmoir] ET]

Attachment: bug1363420.patch

builder diff 
> test-linux64-stylo-sequential/opt-talos-chrome-e10s
> test-linux64-stylo-sequential/opt-talos-dromaeojs-e10s
> test-linux64-stylo-sequential/opt-talos-g1-e10s
> test-linux64-stylo-sequential/opt-talos-g2-e10s
> test-linux64-stylo-sequential/opt-talos-g3-e10s
> test-linux64-stylo-sequential/opt-talos-g4-e10s
> test-linux64-stylo-sequential/opt-talos-other-e10s
> test-linux64-stylo-sequential/opt-talos-perf-reftest
> test-linux64-stylo-sequential/opt-talos-perf-reftest-e10s
> test-linux64-stylo-sequential/opt-talos-svgr-e10s
> test-linux64-stylo-sequential/opt-talos-tp5o-e10s

also tested on m-i

Comment 2

[Kim Moir [:kmoir] ET]

Attachment: bug1363420-3.patch

better patch

> test-linux64-stylo-sequential/opt-talos-chrome-e10s
> test-linux64-stylo-sequential/opt-talos-dromaeojs-e10s
> test-linux64-stylo-sequential/opt-talos-g1-e10s
> test-linux64-stylo-sequential/opt-talos-g2-e10s
> test-linux64-stylo-sequential/opt-talos-g3-e10s
> test-linux64-stylo-sequential/opt-talos-g4-e10s
> test-linux64-stylo-sequential/opt-talos-other-e10s
> test-linux64-stylo-sequential/opt-talos-perf-reftest-e10s
> test-linux64-stylo-sequential/opt-talos-svgr-e10s
> test-linux64-stylo-sequential/opt-talos-tp5o-e10s

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/20fef6e0d682
enable Talos for |linux64-stylo-sequential opt| r=aki DONTBUILD

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/20fef6e0d682

Comment 5

[Bobby Holley (:bholley)]

Hm, this got merged over, but I don't see these jobs on central. Am I looking in the wrong place, or did something not work?

Comment 6

[Kim Moir [:kmoir] ET]

I know what is wrong, patches incoming.

Comment 7

[Kim Moir [:kmoir] ET]

Attachment: bug1363420puppet.patch

I forgot to add the new talos sequential jobs to buildbot, because they run via the buildbot bridge.

Comment 8

[Kim Moir [:kmoir] ET]

Attachment: bug1363420tools.patch

Comment 9

[Kim Moir [:kmoir] ET]

Attachment: bug1363420bb.patch

Comment 10

[Kim Moir [:kmoir] ET]

Attachment: bug1363420builder.diff

builder diff

Comment 11

[Andrei Obreja [:aobreja NOT AVAILABLE][:buildduty]]

Comment on attachment 8866909 [details] [diff] [review]
bug1363420puppet.patch

Looks good.

Comment 12

[Kim Moir [:kmoir] ET]

The buildbot jobs are on the buildbot masters for m-c now, will see if the jobs runn correclty with the next m-c merge.

Comment 13

[Bobby Holley (:bholley)]

(In reply to Kim Moir [:kmoir] from comment #12)
> The buildbot jobs are on the buildbot masters for m-c now, will see if the
> jobs runn correclty with the next m-c merge.

I don't see them on the tip run of m-c, which was pushed a few minutes of comment 12. In fact, I _also_ don't see them for linux64-stylo (the parallel variant). Can you look at this? There are performance patches landed over the weekend that I'd really like to be able to track (ideally on both parallel and sequential, though anything is better than nothing).

Comment 14

[Kim Moir [:kmoir] ET]

I backed out my changes.

However, my changes are all buildbot so it wouldn't impact the taskgraph generation.

Looking at the tree there are no longer any taskcluster talos jobs 
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&filter-searchStr=talos

on 

https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=96b36c5f527dd42e680a230839519eee1fc2c9f3&filter-searchStr=talos

however, there are taskcluster talos jobs on the previous push

https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=1e2fe13035e13b7b4001ade3b48f226957cef5fc&filter-searchStr=talos

If I run 

mach tasksgraph optimized --json -p ~/Downloads/parameters-m-c.yml 

with the current revision vs the last revision, the newer taskgraph doesn't have talos jobs in the tree.  

Not sure what change caused this problem.  But the larger issue is that talos jobs are not included in the taskgraph on m-c.

Comment 15

[Kim Moir [:kmoir] ET]

It seems this was the problem with not running tc talos jobs

https://bugzilla.mozilla.org/show_bug.cgi?id=1364421#c12

Will reland my buildbot changes tomorrow for stylo

Comment 16

[Bobby Holley (:bholley)]

Great, thanks! We're diving into the relative performance of parallel vs sequential traversal this week, so getting that going will be very helpful.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d27b0fc482eb
revert Bug 1363420 - enable Talos for |linux64-stylo-sequential opt| r=kmoir DONTBUILD

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Does this resolve the bug? https://hg.mozilla.org/mozilla-central/rev/d27b0fc482eb

Comment 19

[Kim Moir [:kmoir] ET]

yes, but I the patch in bug  1365128  has to fix the issue with the treeherder display for these jobs.