clean up Atomics.h

RESOLVED FIXED in Firefox 55

Status

()

Core
MFBT
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(3 attachments)

(Assignee)

Description

a year ago
There's some old stuff in here we don't need anymore.
(Assignee)

Comment 1

a year ago
Created attachment 8865910 [details] [diff] [review]
part 1 - remove #ifdeffery in Atomics.h

Every platform where we use GCC has <atomic>, so there's no need to use
GCC-specific __sync* intrinsics anymore.  The <atomic> header may
generate better code for several operations, as well.
Attachment #8865910 - Flags: review?(erahm)
(Assignee)

Comment 2

a year ago
Created attachment 8865911 [details] [diff] [review]
part 2 - remove unneeded MOZ_HAVE_CXX1_ATOMICS

Now that we can use <atomic> everywhere, we don't need to test whether
the standard library we're using has <atomic> support.
Attachment #8865911 - Flags: review?(erahm)
(Assignee)

Comment 3

a year ago
Created attachment 8865912 [details] [diff] [review]
part 3 - minor cleanups to Atomics.h

We can move the <atomic> #include to its normal place in the file now,
as well as merging some namespace blocks at the toplevel.
Attachment #8865912 - Flags: review?(erahm)
Comment on attachment 8865910 [details] [diff] [review]
part 1 - remove #ifdeffery in Atomics.h

Review of attachment 8865910 [details] [diff] [review]:
-----------------------------------------------------------------

Nice cleanup!
Attachment #8865910 - Flags: review?(erahm) → review+
Comment on attachment 8865911 [details] [diff] [review]
part 2 - remove unneeded MOZ_HAVE_CXX1_ATOMICS

Review of attachment 8865911 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #8865911 - Flags: review?(erahm) → review+
Attachment #8865912 - Flags: review?(erahm) → review+

Comment 6

a year ago
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f9dda7a0f6c7
part 1 - remove #ifdeffery in Atomics.h; r=erahm
https://hg.mozilla.org/integration/mozilla-inbound/rev/31c0760423ec
part 2 - remove unneeded MOZ_HAVE_CXX1_ATOMICS; r=erahm
https://hg.mozilla.org/integration/mozilla-inbound/rev/feddbccfffcc
part 3 - minor cleanups to Atomics.h; r=erahm

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f9dda7a0f6c7
https://hg.mozilla.org/mozilla-central/rev/31c0760423ec
https://hg.mozilla.org/mozilla-central/rev/feddbccfffcc
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.