Closed Bug 1363430 Opened 4 years ago Closed 4 years ago

Update kinto-http.js to 4.3.4

Categories

(WebExtensions :: Untriaged, enhancement)

enhancement
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: glasserc, Assigned: glasserc)

Details

Attachments

(1 file)

kinto-http.js has had some releases since it was last updated and it would be good to keep the version in Firefox more-or-less up to date.
Comment on attachment 8865918 [details]
Bug 1363430: Update kinto-http.js to 4.3.4,

https://reviewboard.mozilla.org/r/137500/#review140662

::: services/common/kinto-http-client.js:63
(Diff revision 1)
>  
>  const Cu = Components.utils;
>  
>  Cu.import("resource://gre/modules/Timer.jsm");
>  Cu.importGlobalProperties(['fetch']);
> -const { EventEmitter } = Cu.import("resource://gre/modules/EventEmitter.jsm", {});
> +const { EventEmitter } = Cu.import("resource://devtools/shared/event-emitter.js", {});

My understanding is that devtools is moving out of mozilla-central real soon so you can't rely on devtools modules. Please use resource://gre/modules/EventEmitter.jsm from bug 1356231.

Can you fix that upstream please?
Attachment #8865918 - Flags: review?(MattN+bmo)
Comment on attachment 8865918 [details]
Bug 1363430: Update kinto-http.js to 4.3.4,

https://reviewboard.mozilla.org/r/137500/#review140662

> My understanding is that devtools is moving out of mozilla-central real soon so you can't rely on devtools modules. Please use resource://gre/modules/EventEmitter.jsm from bug 1356231.
> 
> Can you fix that upstream please?

Yes, thanks! I guess some of the stuff in kinto-http.js should really properly live in mozilla-central..
Comment on attachment 8865918 [details]
Bug 1363430: Update kinto-http.js to 4.3.4,

https://reviewboard.mozilla.org/r/137500/#review140858

Thanks
Attachment #8865918 - Flags: review?(MattN+bmo) → review+
Assignee: nobody → eglassercamp
Status: NEW → ASSIGNED
Summary: Update kinto-http.js to 4.3.3 → Update kinto-http.js to 4.3.4
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c17b86def2f6
Update kinto-http.js to 4.3.4, r=MattN
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c17b86def2f6
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.