1363430 - Update kinto-http.js to 4.3.4

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, enhancement)

Description

[Ethan Glasser-Camp (:glasserc)]

kinto-http.js has had some releases since it was last updated and it would be good to keep the version in Firefox more-or-less up to date.

Comment 1

[Ethan Glasser-Camp (:glasserc)]

Attachment: Bug 1363430: Update kinto-http.js to 4.3.4,

Review commit: https://reviewboard.mozilla.org/r/137500/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137500/

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8865918 [details]
Bug 1363430: Update kinto-http.js to 4.3.4,

https://reviewboard.mozilla.org/r/137500/#review140662

::: services/common/kinto-http-client.js:63
(Diff revision 1)
>  
>  const Cu = Components.utils;
>  
>  Cu.import("resource://gre/modules/Timer.jsm");
>  Cu.importGlobalProperties(['fetch']);
> -const { EventEmitter } = Cu.import("resource://gre/modules/EventEmitter.jsm", {});
> +const { EventEmitter } = Cu.import("resource://devtools/shared/event-emitter.js", {});

My understanding is that devtools is moving out of mozilla-central real soon so you can't rely on devtools modules. Please use resource://gre/modules/EventEmitter.jsm from bug 1356231.

Can you fix that upstream please?

Comment 3

[Ethan Glasser-Camp (:glasserc)]

Comment on attachment 8865918 [details]
Bug 1363430: Update kinto-http.js to 4.3.4,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/137500/diff/1-2/

Comment 4

[Ethan Glasser-Camp (:glasserc)]

Comment on attachment 8865918 [details]
Bug 1363430: Update kinto-http.js to 4.3.4,

https://reviewboard.mozilla.org/r/137500/#review140662

> My understanding is that devtools is moving out of mozilla-central real soon so you can't rely on devtools modules. Please use resource://gre/modules/EventEmitter.jsm from bug 1356231.
> 
> Can you fix that upstream please?

Yes, thanks! I guess some of the stuff in kinto-http.js should really properly live in mozilla-central..

Comment 5

[Matthew N. [:MattN]]

Comment on attachment 8865918 [details]
Bug 1363430: Update kinto-http.js to 4.3.4,

https://reviewboard.mozilla.org/r/137500/#review140858

Thanks

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c17b86def2f6
Update kinto-http.js to 4.3.4, r=MattN

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c17b86def2f6