Open Bug 1363432 Opened 7 years ago Updated 2 years ago

Shmem allocation functions should return Maybe<Shmem> instead of a boolean.

Categories

(Core :: Graphics: Layers, enhancement, P3)

enhancement

Tracking

()

People

(Reporter: nical, Unassigned)

Details

(Whiteboard: gfx-noted)

..or the function should be annotated so that the build fails if it returns false. I have a preference towards using Maybe<T>. Anyway, there's a tendency to ignore the result of ShmemAllocator::AllocShmem and friends which can lead to pretty awful things.
(In reply to Nicolas Silva [:nical] from comment #0)
> [...] so that the build fails if it returns false.

I meant if the return value is ignored.
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.