Closed
Bug 1363443
Opened 7 years ago
Closed 7 years ago
Use Cu.isModuleLoaded to see if the module is loaded in PlacesCategoriesStarter.js
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: mccr8, Assigned: mccr8)
References
Details
Attachments
(1 file)
This code checks on the global for the presence of a property "PlacesDBUtils" to decide if PlacesDBUtils.shutdown() needs to be called. It is more direct to just check if PlacesDBUtils.jsm is loaded. The current code will also break if jsms start sharing globals, because PlacesDBUtils will no longer be a property on the global. This patch was originally written by Billm in bug 1186409.
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•7 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0174293131420623c1b34f1bc20ceba815d9e114
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8865946 [details] Bug 1363443 - Use Cu.isModuleLoaded to see if the module is loaded in PlacesCategoriesStarter.js. https://reviewboard.mozilla.org/r/137528/#review140802
Attachment #8865946 -
Flags: review?(mak77) → review+
Pushed by amccreight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1f18d8c7210c Use Cu.isModuleLoaded to see if the module is loaded in PlacesCategoriesStarter.js. r=mak
Pushed by gszorc@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/64913c949426 Use Cu.isModuleLoaded to see if the module is loaded in PlacesCategoriesStarter.js. r=mak
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/64913c949426
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•