Closed
Bug 1363445
Opened 7 years ago
Closed 7 years ago
MessageChannel.addListener is a bit too expensive
Categories
(WebExtensions :: General, defect)
WebExtensions
General
Tracking
(firefox54 wontfix, firefox55 fixed)
RESOLVED
FIXED
mozilla55
People
(Reporter: kmag, Assigned: kmag)
References
Details
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
aswan
:
review+
gchang
:
approval-mozilla-beta-
|
Details |
It gets called a lot.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8865947 [details] Bug 1363445: Speed up MessageChannel.addListener. https://reviewboard.mozilla.org/r/137536/#review140700 Looks like there are only a few places where these are called without an array, we could change it to always take an array but this works too...
Attachment #8865947 -
Flags: review?(aswan) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Comment on attachment 8865947 [details] Bug 1363445: Speed up MessageChannel.addListener. Approval Request Comment [Feature/Bug causing the regression]: N/A [User impact if declined]: This change improves performance in a few key areas, especially when WebExtensions are enabled. [Is this code covered by automated tests?]: Yes. [Has the fix been verified in Nightly?]: No. [Needs manual test from QE? If yes, steps to reproduce]: N/A [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: This is a minor change that simply replaces a relatively expensive operation with a cheaper equivalent. [String changes made/needed]: None
Attachment #8865947 -
Flags: approval-mozilla-beta?
Comment 4•7 years ago
|
||
Thanks Kris. Calling out that we'd love to see this uplifted to 54 given the improvement it causes in tests with Screenshots enabled.
Assignee | ||
Comment 5•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/151d199e0b37642c1adeecb768fff3543dfd05bb Bug 1363445: Speed up MessageChannel.addListener. r=aswan
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/151d199e0b37
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Comment 7•7 years ago
|
||
Screenshots will go live in Fx55 so we don't have to uplift these patches in 54. Beta54-. Mark 54 won't fix.
status-firefox54:
--- → wontfix
Updated•7 years ago
|
Attachment #8865947 -
Flags: approval-mozilla-beta? → approval-mozilla-beta-
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•