1363520 - (DLC) Run CleanupAction from DownloadContentService

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

For some kind of reason CleanupAction is not used by DownloadContentService. Luckily we didn't need it so far.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Bug 1363520 - Run CleanupAction from DownloadContentService.

Review commit: https://reviewboard.mozilla.org/r/138058/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/138058/

Comment 2

[:Grisha Kruglov]

Comment on attachment 8866473 [details]
Bug 1363520 - Run CleanupAction from DownloadContentService.

https://reviewboard.mozilla.org/r/138058/#review148060

::: mobile/android/tests/background/junit4/src/org/mozilla/gecko/dlc/TestCleanupAction.java:1
(Diff revision 1)
> +/* -*- Mode: Java; c-basic-offset: 4; tab-width: 20; indent-tabs-mode: nil; -*-

Tests are public domain.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ecb1be113cb
Run CleanupAction from DownloadContentService. r=Grisha

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for Android build bustage at DownloadContentService.java:137: cannot find symbol:

https://hg.mozilla.org/integration/autoland/rev/b4f0bdb54c69d98dafc0ad2f7ad2f73de86a91e5

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=4ecb1be113cb437ebf56e872faf0913f81352b0b&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=runnable
Build log: https://treeherder.mozilla.org/logviewer.html#?job_id=120928707&repo=autoland

[task 2017-08-04T09:17:27.024732Z] 09:17:27     INFO -  /home/worker/workspace/build/src/mobile/android/base/java/org/mozilla/gecko/dlc/DownloadContentService.java:137: error: cannot find symbol
[task 2017-08-04T09:17:27.024765Z] 09:17:27     INFO -                  action = new CleanupAction();
[task 2017-08-04T09:17:27.024787Z] 09:17:27     INFO -                               ^
[task 2017-08-04T09:17:27.024809Z] 09:17:27     INFO -    symbol:   class CleanupAction
[task 2017-08-04T09:17:27.024829Z] 09:17:27     INFO -    location: class DownloadContentService
[task 2017-08-04T09:17:27.024853Z] 09:17:27     INFO -  Note: Some input files use or override a deprecated API.
[task 2017-08-04T09:17:27.024883Z] 09:17:27     INFO -  Note: Recompile with -Xlint:deprecation for details.
[task 2017-08-04T09:17:27.024911Z] 09:17:27     INFO -  1 error

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8866473 [details]
Bug 1363520 - Run CleanupAction from DownloadContentService.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/138058/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fed159987155
Run CleanupAction from DownloadContentService. r=Grisha

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fed159987155