1363582 - Environment-only js_options don't work properly

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Mike Hommey [:glandium]]

Adding a js_option(env='MOZILLA_OFFICIAL') in bug 1354581 led to:

0:02.45 configure: warning: MOZILLA_OFFICIAL=: invalid host type

This is because the old_configure function in build/moz.configure/old.configure invokes the subconfigure with all the js_options as command line arguments, but old-configure only supports --options passed that way, not OPTIONS.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1363582 - Pass environment-only js_options down to old-configure through the environment.

old-configure does not support being passed them as command line
arguments, so we have to pass them through the environment.

Review commit: https://reviewboard.mozilla.org/r/137752/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137752/

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8866149 [details]
Bug 1363582 - Pass environment-only js_options down to old-configure through the environment.

https://reviewboard.mozilla.org/r/137752/#review141262

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05142d06f6e9
Pass environment-only js_options down to old-configure through the environment. r=chmanchester

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/05142d06f6e9