Forbid boolean operations on @depends functions

RESOLVED FIXED in Firefox 55

Status

Firefox Build System
General
RESOLVED FIXED
a year ago
4 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

(Blocks: 1 bug)

unspecified
mozilla55

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Doing something like "not foo" when foo is a @depends function is never going to do what the user expects, while not necessarily leading to an error (like, when used in set_config). We should make it error out explicitly.
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8866150 [details]
Bug 1363585 - Forbid boolean operations on @depends functions.

https://reviewboard.mozilla.org/r/137756/#review141264
Attachment #8866150 - Flags: review?(cmanchester) → review+

Comment 3

a year ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/044e5f0f2a74
Forbid boolean operations on @depends functions.  r=chmanchester
https://hg.mozilla.org/mozilla-central/rev/044e5f0f2a74
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55

Updated

4 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.