1363585 - Forbid boolean operations on @depends functions

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Mike Hommey [:glandium]]

Doing something like "not foo" when foo is a @depends function is never going to do what the user expects, while not necessarily leading to an error (like, when used in set_config). We should make it error out explicitly.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1363585 - Forbid boolean operations on @depends functions.

Doing something like "not foo" when foo is a @depends function is never
going to do what the user expects, while not necessarily leading to an
error (like, when used in set_config).

It is better to have an error in those cases where it's expected not to
work, at the expense of making templates a little more verbose, rather
than silently do something the user is not expecting.

Review commit: https://reviewboard.mozilla.org/r/137756/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137756/

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8866150 [details]
Bug 1363585 - Forbid boolean operations on @depends functions.

https://reviewboard.mozilla.org/r/137756/#review141264

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/044e5f0f2a74
Forbid boolean operations on @depends functions.  r=chmanchester

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/044e5f0f2a74