Closed Bug 1363585 Opened 4 years ago Closed 4 years ago

Forbid boolean operations on @depends functions

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Doing something like "not foo" when foo is a @depends function is never going to do what the user expects, while not necessarily leading to an error (like, when used in set_config). We should make it error out explicitly.
Comment on attachment 8866150 [details]
Bug 1363585 - Forbid boolean operations on @depends functions.

https://reviewboard.mozilla.org/r/137756/#review141264
Attachment #8866150 - Flags: review?(cmanchester) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/044e5f0f2a74
Forbid boolean operations on @depends functions.  r=chmanchester
https://hg.mozilla.org/mozilla-central/rev/044e5f0f2a74
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.