Closed
Bug 1363643
Opened 7 years ago
Closed 7 years ago
Fix ImageKey deletion in WebRenderBridgeParent
Categories
(Core :: Graphics: WebRender, enhancement)
Core
Graphics: WebRender
Tracking
()
RESOLVED
INVALID
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
Attachments
(1 file, 4 obsolete files)
15.83 KB,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
WebRenderBridgeParent delete ImageKeys in a next transaction. It seems not correct. It seems necessary to remove ImageKeys when a related Epoch ends.
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → sotaro.ikeda.g
Assignee | ||
Updated•7 years ago
|
Summary: Fix old ImageKey deletion in WebRenderBridgeParent → Fix ImageKey deletion in WebRenderBridgeParent
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
Sync wait during removing pipeline is going to be removed by Bug 1360701.
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8866244 -
Attachment is obsolete: true
Assignee | ||
Comment 4•7 years ago
|
||
Attachment #8866251 -
Attachment is obsolete: true
Assignee | ||
Comment 5•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5c01ba8b9523d3d2416f1dad809a9898ab3a0ec8
Assignee | ||
Updated•7 years ago
|
Attachment #8866320 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 6•7 years ago
|
||
update nits.
Attachment #8866320 -
Attachment is obsolete: true
Attachment #8866320 -
Flags: review?(nical.bugzilla)
Assignee | ||
Updated•7 years ago
|
Attachment #8866593 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 7•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa74dea440bce67cba5153fbff93f6db2bfbed9f
Assignee | ||
Comment 8•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d94768c250af7c7db4877cd78bc18ae41a9ee297
Assignee | ||
Comment 9•7 years ago
|
||
Attachment #8866593 -
Attachment is obsolete: true
Attachment #8866593 -
Flags: review?(nical.bugzilla)
Assignee | ||
Updated•7 years ago
|
Attachment #8867114 -
Flags: review?(nical.bugzilla)
Comment 10•7 years ago
|
||
Comment on attachment 8867114 [details] [diff] [review] patch - Fix ImageKey deletion in WebRenderBridgeParent Review of attachment 8867114 [details] [diff] [review]: ----------------------------------------------------------------- I wonder if we can't simply defer the image key deletions to right after the current frame is requested rather than waiting for the transaction to be processed (it seems like it would be simpler (at least in my head), not sure).
Attachment #8867114 -
Flags: review?(nical.bugzilla) → review+
Assignee | ||
Comment 11•7 years ago
|
||
(In reply to Nicolas Silva [:nical] from comment #10) > Comment on attachment 8867114 [details] [diff] [review] > patch - Fix ImageKey deletion in WebRenderBridgeParent > > Review of attachment 8867114 [details] [diff] [review]: > ----------------------------------------------------------------- > > I wonder if we can't simply defer the image key deletions to right after the > current frame is requested rather than waiting for the transaction to be > processed (it seems like it would be simpler (at least in my head), not > sure). I am going to look into it as in another bug.
Assignee | ||
Comment 12•7 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #11) > (In reply to Nicolas Silva [:nical] from comment #10) > I am going to look into it as in another bug. Hmm, I was confused between external image id and ImageKey :( We could remove ImageKey in a next transaction.
Assignee | ||
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•