Closed Bug 1363643 Opened 3 years ago Closed 3 years ago

Fix ImageKey deletion in WebRenderBridgeParent

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set

Tracking

()

RESOLVED INVALID

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file, 4 obsolete files)

WebRenderBridgeParent delete ImageKeys in a next transaction. It seems not correct. It seems necessary to remove ImageKeys when a related Epoch ends.
Assignee: nobody → sotaro.ikeda.g
Summary: Fix old ImageKey deletion in WebRenderBridgeParent → Fix ImageKey deletion in WebRenderBridgeParent
Sync wait during removing pipeline is going to be removed by Bug 1360701.
Attachment #8866244 - Attachment is obsolete: true
Attachment #8866251 - Attachment is obsolete: true
Attachment #8866320 - Flags: review?(nical.bugzilla)
update nits.
Attachment #8866320 - Attachment is obsolete: true
Attachment #8866320 - Flags: review?(nical.bugzilla)
Attachment #8866593 - Flags: review?(nical.bugzilla)
Depends on: 1364302
Attachment #8866593 - Attachment is obsolete: true
Attachment #8866593 - Flags: review?(nical.bugzilla)
Attachment #8867114 - Flags: review?(nical.bugzilla)
Comment on attachment 8867114 [details] [diff] [review]
patch - Fix ImageKey deletion in WebRenderBridgeParent

Review of attachment 8867114 [details] [diff] [review]:
-----------------------------------------------------------------

I wonder if we can't simply defer the image key deletions to right after the current frame is requested rather than waiting for the transaction to be processed (it seems like it would be simpler (at least in my head), not sure).
Attachment #8867114 - Flags: review?(nical.bugzilla) → review+
(In reply to Nicolas Silva [:nical] from comment #10)
> Comment on attachment 8867114 [details] [diff] [review]
> patch - Fix ImageKey deletion in WebRenderBridgeParent
> 
> Review of attachment 8867114 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I wonder if we can't simply defer the image key deletions to right after the
> current frame is requested rather than waiting for the transaction to be
> processed (it seems like it would be simpler (at least in my head), not
> sure).

I am going to look into it as in another bug.
(In reply to Sotaro Ikeda [:sotaro] from comment #11)
> (In reply to Nicolas Silva [:nical] from comment #10)
> I am going to look into it as in another bug.

Hmm, I was confused between external image id and ImageKey :( We could remove ImageKey in a next transaction.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.