Closed Bug 1363645 Opened 4 years ago Closed 4 years ago

Update translations for Pocket

Categories

(Firefox :: Pocket, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: flod, Assigned: mixedpuppy)

References

Details

Attachments

(1 file)

We have new translations for Pocket, we should add them to m-c.
@shane
In bug 1325239 you told that these changes should start from a PR against https://github.com/mozilla-partners/pocket

But that repository doesn't have localization files, only en-US. Can you explain what the process should be?
Flags: needinfo?(mixedpuppy)
Depends on: 1363648
It's in the readme (bad formatting) at https://github.com/mozilla-partners/pocket

pull both repositories into the same base dir:

mkdir sources 
cd sources 
git clone git@github.com:mozilla-partners/pocket.git 
git clone git@github.com:mozilla-l10n/pocket-l10n.git 
cd pocket 
make

To prepare a patch for landing on m-c (be sure to also have a clone of m-c in sources)

make land

To prepare a xpi for gofaster

make xpi

There could be patches on m-c that need to be pushed back to the pocket repo first.
Flags: needinfo?(mixedpuppy)
I think you updated GitHub last time I touched files. Having said that, it fails for me

Sadly make dies for me, and I have no idea where to start from.

removing ../../../mozilla/mercurial/mozilla-unified/browser/extensions/pocket/locale/zh-TW/pocket.properties
not removing ../../../mozilla/mercurial/mozilla-unified/browser/extensions/pocket/locale/id: no tracked files
make: *** [land] Error 1
Uhm, I managed to make it work by removing /* here
https://github.com/mozilla-partners/pocket/blob/master/Makefile#L30

But the resulting changes in mozilla-central are way too big. I think we need a real dev to take a look once bug 1363648 is fixed, otherwise I can land only the l10n bits like I did in the previous bug.
@shane
I need some help. I can't update the add-on using make, because that requires someone who understands the code. Are you the right person to help in case? As said, I could update only the l10n bits in m-c if needed.
Flags: needinfo?(mixedpuppy)
Attachment #8867850 - Flags: review?(gijskruitbosch+bugs)
Attachment #8867850 - Flags: review?(francesco.lodolo)
I updated the pocket git repo, it hadn't been synchronized with mozilla-central.  Flod, can you review the patch?  Gijs, I added you, but it's probably really not necessary.
Flags: needinfo?(mixedpuppy)
Assignee: nobody → mixedpuppy
Attachment #8867850 - Flags: review?(gijskruitbosch+bugs)
Flod can add me back if he thinks it's necessary.

Related: really, we have a fy-NL translation but not an nl-NL one? That is... odd.
Comment on attachment 8867850 [details]
Bug 1363645 update pocket l10n

https://reviewboard.mozilla.org/r/139386/#review142724

It looks, thanks.

P.S. Dutch has been in there from the beginning, the first list is only for locale codes with hyphens ;-)
Attachment #8867850 - Flags: review?(francesco.lodolo) → review+
https://hg.mozilla.org/mozilla-central/rev/6821d95e317e
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.