1363645 - Update translations for Pocket

Status: RESOLVED FIXED

(Firefox :: Pocket, enhancement)

Description

[Francesco Lodolo [:flod]]

We have new translations for Pocket, we should add them to m-c.

Comment 1

[Francesco Lodolo [:flod]]

@shane
In bug 1325239 you told that these changes should start from a PR against https://github.com/mozilla-partners/pocket

But that repository doesn't have localization files, only en-US. Can you explain what the process should be?

Comment 2

[Shane Caraveo (:mixedpuppy)]

It's in the readme (bad formatting) at https://github.com/mozilla-partners/pocket

pull both repositories into the same base dir:

mkdir sources 
cd sources 
git clone [e-mail]:mozilla-partners/pocket.git 
git clone [e-mail]:mozilla-l10n/pocket-l10n.git 
cd pocket 
make

To prepare a patch for landing on m-c (be sure to also have a clone of m-c in sources)

make land

To prepare a xpi for gofaster

make xpi

There could be patches on m-c that need to be pushed back to the pocket repo first.

Comment 3

[Francesco Lodolo [:flod]]

I think you updated GitHub last time I touched files. Having said that, it fails for me

Sadly make dies for me, and I have no idea where to start from.

removing ../../../mozilla/mercurial/mozilla-unified/browser/extensions/pocket/locale/zh-TW/pocket.properties
not removing ../../../mozilla/mercurial/mozilla-unified/browser/extensions/pocket/locale/id: no tracked files
make: *** [land] Error 1

Comment 4

[Francesco Lodolo [:flod]]

Uhm, I managed to make it work by removing /* here
https://github.com/mozilla-partners/pocket/blob/master/Makefile#L30

But the resulting changes in mozilla-central are way too big. I think we need a real dev to take a look once bug 1363648 is fixed, otherwise I can land only the l10n bits like I did in the previous bug.

Comment 5

[Francesco Lodolo [:flod]]

@shane
I need some help. I can't update the add-on using make, because that requires someone who understands the code. Are you the right person to help in case? As said, I could update only the l10n bits in m-c if needed.

Comment 6

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1363645 update pocket l10n

Review commit: https://reviewboard.mozilla.org/r/139386/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/139386/

Comment 7

[Shane Caraveo (:mixedpuppy)]

I updated the pocket git repo, it hadn't been synchronized with mozilla-central.  Flod, can you review the patch?  Gijs, I added you, but it's probably really not necessary.

Comment 8

[:Gijs (he/him)]

Flod can add me back if he thinks it's necessary.

Related: really, we have a fy-NL translation but not an nl-NL one? That is... odd.

Comment 9

[Francesco Lodolo [:flod]]

Comment on attachment 8867850 [details]
Bug 1363645 update pocket l10n

https://reviewboard.mozilla.org/r/139386/#review142724

It looks, thanks.

P.S. Dutch has been in there from the beginning, the first list is only for locale codes with hyphens ;-)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6821d95e317e
update pocket l10n r=flod

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6821d95e317e