Repeated Crashes [@ IPCError-content | PAltDataOutputStream::Msg_Error Route error: message sent to unknown actor ID ]

RESOLVED FIXED in Firefox 55

Status

()

--
critical
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: ananuti, Assigned: valentin)

Tracking

(Blocks: 1 bug, {crash})

Trunk
mozilla55
All
Windows 10
crash
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox53 unaffected, firefox54 unaffected, firefox55 fixed)

Details

(Whiteboard: [necko-active], crash signature)

Attachments

(1 attachment)

(Assignee)

Comment 1

2 years ago
This occurs because of a race in destroying the AltDataOutputStreamChild

AltDataOutputStreamChild::Close -> SendClose()
AltDataOutputStreamChild::Release -> Send__delete__()
AltDataOutputStreamParent::RecvClose() -> SendError()
AltDataOutputStreamParent::ActorDestroy -> mIPCOpen = false
AltDataOutputStreamChild::RecvError -> === The object has already been destroyed ===

We need to add releasing mechanism similar to the one in HttpChannelChild/Parent.
Assignee: nobody → valentin.gosu
Whiteboard: [necko-active]
Comment hidden (mozreview-request)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8866326 [details]
Bug 1363653 - Make AltDataOutputStreamParent not send any messages after object destruction

https://reviewboard.mozilla.org/r/137958/#review141642

::: netwerk/protocol/http/AltDataOutputStreamChild.cpp:18
(Diff revision 1)
>    MOZ_ASSERT(NS_IsMainThread(), "Main thread only");
>    --mRefCnt;
>    NS_LOG_RELEASE(this, mRefCnt, "AltDataOutputStreamChild");
>  
>    if (mRefCnt == 1 && mIPCOpen) {
> -    // Send_delete calls NeckoChild::PAltDataOutputStreamChild, which will release
> +    // Only the reference is in the IPDL one. After the parent replies back with

maybe check spelling of the comment
Attachment #8866326 - Flags: review?(honzab.moz) → review+
Comment hidden (mozreview-request)

Comment 5

a year ago
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/266e09e18a8e
Make AltDataOutputStreamParent not send any messages after object destruction r=mayhemer

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/266e09e18a8e
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
status-firefox53: --- → unaffected
status-firefox54: --- → unaffected
status-firefox-esr52: --- → unaffected
You need to log in before you can comment on or make changes to this bug.