Closed Bug 1363664 Opened 3 years ago Closed 3 years ago

Stylo: Add bindings for Servo-side setting of nsStyleGridTemplate

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: waffles, Assigned: waffles)

Details

Attachments

(2 files)

No description provided.
Comment on attachment 8866266 [details]
Bug 1363664 - Add bindings for StyleGridTemplate and nsTArray<nsString>;

https://reviewboard.mozilla.org/r/137884/#review140984
Attachment #8866266 - Flags: review?(cam) → review+
This fails hazard build - https://treeherder.mozilla.org/#/jobs?repo=try&revision=98e2559cba5a4fd9f80e08c15449b7d996faf195

Previously (i.e., before updating the analyzeHeapWrites.js), this was the log - https://bugzilla.mozilla.org/show_bug.cgi?id=1362843#c14

Now, only one error shows up, and that's on Gecko_ResizeTArrayForStrings. I've no idea how to fix that. Manish, could you take a look? Bobby has asked me to check with you and whitelist the function.
Flags: needinfo?(manishearth)
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/feea2db3ddbe
Add bindings for StyleGridTemplate and nsTArray<nsString>; r=heycam
Never mind. Having a template didn't cause any trouble :)
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Flags: needinfo?(manishearth)
Resolution: --- → FIXED
Comment on attachment 8869129 [details]
Bug 1363664 - Update test expectations for some grid-* properties;

https://reviewboard.mozilla.org/r/140762/#review144218

::: layout/reftests/css-grid/reftest.list:189
(Diff revision 4)
> -fails-if(stylo) == grid-repeat-auto-fill-fit-008.html grid-repeat-auto-fill-fit-008-ref.html
> -fails-if(stylo) == grid-repeat-auto-fill-fit-009.html grid-repeat-auto-fill-fit-009-ref.html
> +== grid-repeat-auto-fill-fit-008.html grid-repeat-auto-fill-fit-008-ref.html
> +== grid-repeat-auto-fill-fit-009.html grid-repeat-auto-fill-fit-009-ref.html
>  fails-if(stylo) == grid-repeat-auto-fill-fit-010.html grid-repeat-auto-fill-fit-010-ref.html
>  fails-if(stylo) == grid-repeat-auto-fill-fit-011.html grid-repeat-auto-fill-fit-010-ref.html
>  == grid-item-blockifying-001.html grid-item-blockifying-001-ref.html
> -fails-if(stylo) == grid-fragmentation-001.html grid-fragmentation-001-ref.html
> +asserts(0-10) == grid-fragmentation-015.html grid-fragmentation-015-ref.html # bug 1144852 (due to vertical writing-mode)

`asserts-if(stylo, 0-10)`
Attachment #8869129 - Flags: review?(manishearth) → review+
Pushed by manishearth@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/047726883556
Add bindings for StyleGridTemplate and nsTArray<nsString>; r=heycam
https://hg.mozilla.org/integration/autoland/rev/1f73348a59e5
Update test expectations for some grid-* properties; r=manishearth
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
In general don't mark as fixed till it hits m-c (which will happen automatically)
You need to log in before you can comment on or make changes to this bug.