Move the repeat information outside of the message type

RESOLVED FIXED in Firefox 55

Status

enhancement
P1
normal
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: nchevobbe, Assigned: nchevobbe)

Tracking

unspecified
Firefox 55
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [console-html])

Attachments

(3 attachments)

We could have a repeatById Map for this instead of mutating the message object
Priority: -- → P2
Whiteboard: [console-html]
Blocks: 1364035
Flags: qe-verify?
Flags: qe-verify? → qe-verify-
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: P2 → P1
Iteration: --- → 55.7 - Jun 12
Comment on attachment 8874407 [details]
Bug 1363680 - Move the repeat information outside of the message type.

https://reviewboard.mozilla.org/r/145760/#review149764
Attachment #8874407 - Flags: review?(odvarko) → review+
Comment on attachment 8874409 [details]
Bug 1363680 - Adapt mocha tests.

https://reviewboard.mozilla.org/r/145764/#review149768

Looks good to me!

R+ assuming try is green

Honza
Attachment #8874409 - Flags: review?(odvarko) → review+
Blocks: 1370268
https://hg.mozilla.org/mozilla-central/rev/6daa1d690d1a
https://hg.mozilla.org/mozilla-central/rev/60f2048eab81
https://hg.mozilla.org/mozilla-central/rev/6af1b1e458f0
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.