Closed
Bug 1363680
Opened 7 years ago
Closed 7 years ago
Move the repeat information outside of the message type
Categories
(DevTools :: Console, enhancement, P1)
DevTools
Console
Tracking
(firefox55 fixed)
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
Details
(Whiteboard: [console-html])
Attachments
(3 files)
We could have a repeatById Map for this instead of mutating the message object
Assignee | ||
Updated•7 years ago
|
Priority: -- → P2
Assignee | ||
Updated•7 years ago
|
Whiteboard: [console-html]
Updated•7 years ago
|
Flags: qe-verify?
Updated•7 years ago
|
Flags: qe-verify? → qe-verify-
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: P2 → P1
Updated•7 years ago
|
Iteration: --- → 55.7 - Jun 12
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8874407 [details] Bug 1363680 - Move the repeat information outside of the message type. https://reviewboard.mozilla.org/r/145760/#review149764
Attachment #8874407 -
Flags: review?(odvarko) → review+
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8874408 [details] Bug 1363680 - Update stubs. https://reviewboard.mozilla.org/r/145762/#review149766
Attachment #8874408 -
Flags: review?(odvarko) → review+
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8874409 [details] Bug 1363680 - Adapt mocha tests. https://reviewboard.mozilla.org/r/145764/#review149768 Looks good to me! R+ assuming try is green Honza
Attachment #8874409 -
Flags: review?(odvarko) → review+
Assignee | ||
Comment 10•7 years ago
|
||
TRY looks okay https://treeherder.mozilla.org/#/jobs?repo=try&revision=a1ad0f67a3e3e34b8542bf49832e5fa739ac063d Let's push this
Comment 11•7 years ago
|
||
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6daa1d690d1a Move the repeat information outside of the message type. r=Honza https://hg.mozilla.org/integration/autoland/rev/60f2048eab81 Update stubs. r=Honza https://hg.mozilla.org/integration/autoland/rev/6af1b1e458f0 Adapt mocha tests. r=Honza
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6daa1d690d1a https://hg.mozilla.org/mozilla-central/rev/60f2048eab81 https://hg.mozilla.org/mozilla-central/rev/6af1b1e458f0
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•