Closed Bug 1363680 Opened 4 years ago Closed 3 years ago

Move the repeat information outside of the message type

Categories

(DevTools :: Console, enhancement, P1)

enhancement

Tracking

(firefox55 fixed)

RESOLVED FIXED
Firefox 55
Iteration:
55.7 - Jun 12
Tracking Status
firefox55 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

(Whiteboard: [console-html])

Attachments

(3 files)

We could have a repeatById Map for this instead of mutating the message object
Priority: -- → P2
Whiteboard: [console-html]
Blocks: 1364035
Flags: qe-verify?
Flags: qe-verify? → qe-verify-
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: P2 → P1
Iteration: --- → 55.7 - Jun 12
Comment on attachment 8874407 [details]
Bug 1363680 - Move the repeat information outside of the message type.

https://reviewboard.mozilla.org/r/145760/#review149764
Attachment #8874407 - Flags: review?(odvarko) → review+
Comment on attachment 8874409 [details]
Bug 1363680 - Adapt mocha tests.

https://reviewboard.mozilla.org/r/145764/#review149768

Looks good to me!

R+ assuming try is green

Honza
Attachment #8874409 - Flags: review?(odvarko) → review+
Blocks: 1370268
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.