Closed Bug 1363685 Opened 4 years ago Closed 4 years ago

Revert string addonDebugging.label2 to addonDebugging.label (follow up to 1363100)

Categories

(DevTools :: about:debugging, defect, P3)

defect

Tracking

(firefox55 fixed)

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

Attachments

(1 file)

cf Bug 1363100 comment 13 and discussion thereafter

I wanted to push a follow up directly on inbound, but it looks like it was not updated from central yet, so I'll handle that in another bug.
Comment on attachment 8866299 [details]
Bug 1363685 - revert addonDebugging.label2 to addonDebugging.label;

https://reviewboard.mozilla.org/r/137924/#review141034
Attachment #8866299 - Flags: review?(francesco.lodolo) → review+
Pushed by francesco.lodolo@mozillaitalia.org:
https://hg.mozilla.org/integration/autoland/rev/dfb60edacd2f
revert addonDebugging.label2 to addonDebugging.label;r=flod
Backed out for failing devtools/client/aboutdebugging/test/browser_addons_debug_bootstrapped.js (the string id in the caller hadn't been updated):

https://hg.mozilla.org/integration/autoland/rev/44ded04dd69337c86e33be791e6dc7c1b0a7bb23

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=dfb60edacd2fa877de9c881a7c96499c79d31253&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=97994288&repo=autoland

04:46:57     INFO - Entering test bound 
04:46:57     INFO - opening about:debugging
04:46:57     INFO - Adding a new tab with URL: about:debugging#addons
04:46:57     INFO - Buffered messages logged at 04:43:58
04:46:57     INFO - Tab added and finished loading
04:46:57     INFO - Console message: [JavaScript Error: "TypeError: node is null" {file: "resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/vendor/react-dev.js" line: 8442}]
04:46:57     INFO - Console message: [JavaScript Error: "TypeError: node is null" {file: "resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/vendor/react-dev.js" line: 8442}]
04:46:57     INFO - Console message: [JavaScript Error: "TypeError: node is null" {file: "resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/vendor/react-dev.js" line: 8442}]
04:46:57     INFO - Buffered messages logged at 04:45:27
04:46:57     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 1
04:46:57     INFO - Buffered messages finished
04:46:57     INFO - TEST-UNEXPECTED-FAIL | devtools/client/aboutdebugging/test/browser_addons_debug_bootstrapped.js | Test timed out -
Flags: needinfo?(jdescottes)
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d707450b2592
revert addonDebugging.label2 to addonDebugging.label;r=flod
Flags: needinfo?(jdescottes)
https://hg.mozilla.org/mozilla-central/rev/d707450b2592
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.