1363687 - Have gBrowser.loadOneTab() provide a valid triggeringPrincipal

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P2)

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1363687_loadonetab_triggeringprincipal.patch

Gijs, as discussed we would like to pass a valid triggeringPrincpal within addTab. Over in Bug 1362993 we automatically rewrite tests to use BrowserTestUtils.addTab(...) which provides the triggeringPrincipal. Anyway, there are only a few occurrences within tests were we use gBrowser.loadOneTab(...) so I think it makes sense to manually update those tests to pass a valid triggeringPrincipal. Please note that "loadOneTab" [1] already passes the principal on to addTab internally. So I think this is all there is to do  in terms of updating tests.

https://dxr.mozilla.org/mozilla-central/source/browser/base/content/tabbrowser.xml#1481

Comment 2

[:Gijs (he/him)]

Comment on attachment 8866323 [details] [diff] [review]
bug_1363687_loadonetab_triggeringprincipal.patch

Review of attachment 8866323 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/general/browser_aboutSupport_newtab_security_state.js
@@ +15,5 @@
>      allowThirdPartyFixup: false,
>      relatedToCurrent: false,
>      skipAnimation: true,
> +    allowMixedContent: false,
> +    triggeringPrincipal: Services.scriptSecurityManager.getSystemPrincipal()

Nit: please add trailing comma here and elsewhere.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f608b9c01ca
Have gBrowser.loadOneTab() provide a valid triggeringPrincipal. r=gijs

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5f608b9c01ca