1363696 - Compute the indent of a message in the message add reducer

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

At the moment, we get the length of the parent groups of the message in ConsoleOutput. This should be done at earlier stage and put into the message object since it isn't a property that will change.

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Bug 1363696 - Compute the indent of a message in the message add reducer;

Review commit: https://reviewboard.mozilla.org/r/142830/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/142830/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8871359 [details]
Bug 1363696 - Compute the indent of a message in the message add reducer;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/142830/diff/1-2/

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8871359 [details]
Bug 1363696 - Compute the indent of a message in the message add reducer;

https://reviewboard.mozilla.org/r/142830/#review146792

Looking good, thanks Honza !

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac956e9a5d32
Compute the indent of a message in the message add reducer; r=nchevobbe

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for eslint failure at devtools/client/webconsole/new-console-output/components/console-output.js:85:

https://hg.mozilla.org/integration/autoland/rev/757120797ede591897b778d35fc49d0addfd6a1c

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=ac956e9a5d32b82c7a0d9d6436b605f0705820fc&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=102256195&repo=autoland
> TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/devtools/client/webconsole/new-console-output/components/console-output.js:85:7 | 'groups' is assigned a value but never used. (no-unused-vars)

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8871359 [details]
Bug 1363696 - Compute the indent of a message in the message add reducer;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/142830/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2dbd37535672
Compute the indent of a message in the message add reducer; r=nchevobbe

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Sorry about that.
I fixed the problem and new try looks good:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=40ab02ba10cc30bea3a6705cdcd66cca7bcccdc2

Trying to land again.

Honza

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2dbd37535672