1363716 - Disable TFO with Lavasoft

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is 
report bp-4f20c87c-7d68-4c8a-ae83-d3dfe0170510.
=============================================================

Seen while looking at nightly crash data - although only one crash thus far, seems it might be related to some of the networking changes we have made recently: http://bit.ly/2qr7WQI. So far the lone crash is on Win 10.

Possible regression range based on Build ID: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1fda52a1f3b81cf1a821155998dca637bb64e3d9&tochange=4b8939ed128172fcd3433ee25f336a8c1ba77ab0

ni on Dragana to see if this indeed related to recent work.

Comment 1

[Dragana Damjanovic [:dragana]]

This is interesting.

0 		@0x0 	
1 	nss3.dll 	SSL_SetNextProtoNego 	security/nss/lib/ssl/sslsock.c:1956
Ø 2 	pmls64.dll 	pmls64.dll@0x72b0d 	
3 	xul.dll 	mozilla::dom::Selection::AddItem(nsRange*, int*, bool) 	layout/generic/nsSelection.cpp:3855
4 		@0x2100000007 	
5 	xul.dll 	mozilla::net::nsHttpConnection::InitSSLParams(bool, bool) 	netwerk/protocol/http/nsHttpConnection.cpp:878
6 	xul.dll 	mozilla::net::nsHttpConnection::SetupSSL() 	netwerk/protocol/http/nsHttpConnection.cpp:707
7 	xul.dll 	mozilla::net::nsHttpConnection::IsAlive() 	netwerk/protocol/http/nsHttpConnection.cpp:994
8 	xul.dll 	mozilla::net::nsHttpConnection::CanReuse() 	netwerk/protocol/http/nsHttpConnection.cpp:934
9 	xul.dll 	mozilla::net::nsHttpConnectionMgr::OnMsgReclaimConnection(int, mozilla::net::ARefBase*) 	netwerk/protocol/http/nsHttpConnectionMgr.cpp:2644
10 	xul.dll 	mozilla::net::nsHttpConnectionMgr::nsHalfOpenSocket::SetupConn(nsIAsyncOutputStream*, bool) 	netwerk/protocol/http/nsHttpConnectionMgr.cpp:3789
11 	xul.dll 	mozilla::net::nsHttpConnectionMgr::nsHalfOpenSocket::StartFastOpen() 	netwerk/protocol/http/nsHttpConnectionMgr.cpp:3547

Comment 2

[Patrick McManus [:mcmanus]]

this also implicates lavasoft

Comment 3

[Marcia Knous [:marcia]]

TFO was turned on again in Bug 1367390, we will keep these crashes open until Dragana evaluates whether they should be closed or not.

Comment 4

[Dragana Damjanovic [:dragana]]

This issue appears only for one user and it was 4 crashes in a row. Since we run TFO second test only for a day, I cannot confirm that this is fix.

Comment 5

[Dragana Damjanovic [:dragana]]

All crashes have:
pmls64.dll 	4.0.20.98 	FDD6517F76E64641AAC65AC8055732151 	OSMIMHK64.pdb

the same as in bug 1363376.

Comment 6

[Julien Cristau [:jcristau] (back April 22)]

TFO crash, marking 55 as disabled.

Comment 7

[Dragana Damjanovic [:dragana]]

I will disable TFO if pmls64.dll and rlls64.dll(bug 1363376) are detected.

Comment 8

[Dragana Damjanovic [:dragana]]

Attachment: bug_1363716.patch

Comment 9

[Dragana Damjanovic [:dragana]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=83d6043f021660144fa18b943b89d8dc11ad9156

Comment 10

[Dragana Damjanovic [:dragana]]

Attachment: bug_1363716.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=357b7fa675aad4d8112d6b2579bd9b1cdd880e50

Comment 11

[Patrick McManus [:mcmanus]]

A comment about lavasoft would be useful :)

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b67c39184335
disable TFO if pmls64.dll and rlls64.dll are detected. r=mcmanus

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b67c39184335