Is it "all_child" or "all_childs"?

NEW
Unassigned

Status

()

Toolkit
Telemetry
P3
normal
7 months ago
7 months ago

People

(Reporter: chutten, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

7 months ago
The docs say that a valid value for "record_in_processes" is "all_child", but the code requires "all_childs" (and the enum AllChilds).

Which should it be?
(Reporter)

Updated

7 months ago
Flags: needinfo?(gfritzsche)
(Reporter)

Updated

7 months ago
Flags: needinfo?(alessio.placitelli)
Given bug 1278556 comment 3, I think the doc is wrong and the code is correct.

(In reply to Georg Fritzsche [:gfritzsche] from comment #3)
> ...
> * possibly support "all" or "all childs" to not make measurements that run
> everywhere too complicated
> 
> ...
Flags: needinfo?(alessio.placitelli)
(Reporter)

Comment 2

7 months ago
But should we "fix" the code to match the docs (and English grammar)?
As a non-native speaker i'll ask: Does "all_childs" sound correct?
If yes, let's just fix the docs.
Points: --- → 1
Flags: needinfo?(gfritzsche)
Priority: -- → P2
(Reporter)

Comment 4

7 months ago
"all_childs" sounds incorrect. In English (ugh.) the plural of "child" is "children"
Priority: P2 → P3
You need to log in before you can comment on or make changes to this bug.