Closed
Bug 1363783
Opened 7 years ago
Closed 7 years ago
Repeated ping data from Flash SHIELD study
Categories
(Core Graveyard :: Plug-ins, defect, P1)
Core Graveyard
Plug-ins
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: benjamin, Unassigned)
References
Details
The Flash SHIELD study addon appears not to be clearing old data when it sends the custom ping. STR: * Firefox profile with the Flash SHIELD study active, non-control * visit http://finance.sina.com.cn ** The CTP bar appears * shut down the browser * examine the custom ping payload Expected: * one entry in the "docs" array with one or more Flash objects at least one of which has a ctp-bar annotation. Actual: * four entries in the docs array, with this data: { "clientID": "dfbece14-ea1d-4673-a745-88bd9be9710e", "locale": "en-US", "geo": "US", "flashVersion": "25.0.0.171", "datetime": 1494427634842, "profileAge": 0, "daysInExperiment": 0, "experimentGroup": "test-waiting", "docs": [ { "host": "http://finance.sina.com.cn", "ctaSetting": "default", "flashClassification": "unknown", "is3rdParty": false, "userAction": [ "page-refreshed" ], "ctpVia": null, "docshellId": "{cd487bf2-175d-4f56-b3f3-9262a919ae22}", "user-feedback": {}, "flashObjs": [ { "path": "http://i2.sinaimg.cn/cj/hsuan/flash/indices/Indices140504q.swf", "classification": "allowed", "is3rdParty": true, "width": 730, "height": 80, "clickedOnOverlay": false }, { "path": "http://i3.sinaimg.cn/cj/yw/flash/GC130522a.swf", "classification": "allowed", "is3rdParty": true, "width": 730, "height": 80, "clickedOnOverlay": false } ], "subDocs": [ { "host": "https://current.sina.com.cn", "ctaSetting": "default", "flashClassification": "unknown", "is3rdParty": true, "userAction": [], "ctpVia": null, "docshellId": "{3437a064-d2b8-4a9a-894d-583dc595cd1e}", "user-feedback": {}, "flashObjs": [ { "path": "https://passport.weibo.com/images/visitor/fonts.swf", "classification": "allowed", "is3rdParty": true, "width": 1, "height": 1, "clickedOnOverlay": false } ], "subDocs": [] } ] }, { "host": "http://finance.sina.com.cn", "ctaSetting": "default", "flashClassification": "unknown", "is3rdParty": false, "userAction": [], "ctpVia": null, "docshellId": "{4d6a7f37-e0f9-42bf-ad04-33a675389784}", "user-feedback": {}, "flashObjs": [ { "path": "http://i3.sinaimg.cn/cj/yw/flash/GC130522a.swf", "classification": "ctp-bar", "is3rdParty": true, "width": 730, "height": 80, "clickedOnOverlay": false }, { "path": "http://i2.sinaimg.cn/cj/hsuan/flash/indices/Indices140504q.swf", "classification": "ctp-bar", "is3rdParty": true, "width": 730, "height": 80, "clickedOnOverlay": false } ], "subDocs": [] }, { "host": "http://finance.sina.com.cn", "ctaSetting": "default", "flashClassification": "unknown", "is3rdParty": false, "userAction": [], "ctpVia": null, "docshellId": "{cd487bf2-175d-4f56-b3f3-9262a919ae22}", "user-feedback": {}, "flashObjs": [ { "path": "http://i2.sinaimg.cn/cj/hsuan/flash/indices/Indices140504q.swf", "classification": "allowed", "is3rdParty": true, "width": 730, "height": 80, "clickedOnOverlay": false }, { "path": "http://i3.sinaimg.cn/cj/yw/flash/GC130522a.swf", "classification": "allowed", "is3rdParty": true, "width": 730, "height": 80, "clickedOnOverlay": false } ], "subDocs": [] }, { "host": "http://finance.sina.com.cn", "ctaSetting": "default", "flashClassification": "unknown", "is3rdParty": false, "userAction": [], "ctpVia": null, "docshellId": "{defaba21-6fc7-4632-a48f-eace28294b2a}", "user-feedback": {}, "flashObjs": [ { "path": "http://i3.sinaimg.cn/cj/yw/flash/GC130522a.swf", "classification": "ctp-bar", "is3rdParty": true, "width": 730, "height": 80, "clickedOnOverlay": false }, { "path": "http://i2.sinaimg.cn/cj/hsuan/flash/indices/Indices140504q.swf", "classification": "ctp-bar", "is3rdParty": true, "width": 730, "height": 80, "clickedOnOverlay": false } ], "subDocs": [] } ], "counts": { "totalDocs": 25, "flashDocs": 4, "flashObjs": { "total": 9, "fallbacked": 0, "allowed": 5, "denied": 0, "ctp": 4 }, "user-action": { "allow": 0, "allow-and-remember": 0, "deny": 0, "feedback-given": 0 } } } I debugged through some of this and data from prior sessions is ending up in this ping. I put a log statement in lib/dataCollection.js `init`, and regularly at startup ss.storage.pingEvents is not the empty list. This data is *supposed* to be cleared by this code in `rollUpEvents`: const allEvents = ss.storage.pingEvents || []; ss.storage.pingEvents = []; Is it possible that at browser shutdown (the uninit function in lib/datacollection.js) it's too late to write to ss.storage and so this is ineffective?
Flags: needinfo?(dothayer)
Comment 1•7 years ago
|
||
(In reply to Benjamin Smedberg [:bsmedberg] from comment #0) > Is it possible that at browser shutdown (the uninit function in > lib/datacollection.js) it's too late to write to ss.storage and so this is > ineffective? Yup, that seems to be what's going on. Since this data should always have been sent during shutdown, I'm going to additionally clear the list on init. Created two issues to track shutdown-related issues on the repo: https://github.com/squarewave/shield-study-essential-flash/issues/2 https://github.com/squarewave/shield-study-essential-flash/issues/3 Felipe, would you mind reviewing the two linked commits?
Flags: needinfo?(dothayer) → needinfo?(felipc)
Reporter | ||
Comment 3•7 years ago
|
||
Can you add/bump a version number in the custom ping so that I can separate out pings with this fixed?
Flags: needinfo?(dothayer)
Comment 4•7 years ago
|
||
Sure thing! https://github.com/squarewave/shield-study-essential-flash/commit/73b4ae05e52fbd0ed0e7ba7b2ddd50d7db70b967
Flags: needinfo?(dothayer)
Comment 5•7 years ago
|
||
This should be resolved now in pings with version == 1.
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•