Closed Bug 1363792 Opened 7 years ago Closed 7 years ago

Shavar plugin blocklist updates, week 2

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: benjamin, Assigned: Felipe)

References

Details

User Story

3rd-party blocklist:
disqusads.com
doubleclick.net
googlesyndication.com
www.playviking.com
accounts.google.com
2mdn.net
adnxs.com
cmptch.com
platform.twitter.com
hangouts.google.com
adap.tv
notifications.google.com
ads.yahoo.com
xscores.com
sina.com.cn
youtube.com
eclick.baidu.com
pictela.net
exoticads.com

1st-party blocklist:
facebook.com *but* apps.facebook.com needs to be allowed
embed.sendtonews.com
fqtag.com
translate.google.com
This bug is filed to keep track of the shavar updates required for week 2 of the SHIELD study. The list will be kept in the user story.
Assignee: nobody → felipc
Status: NEW → ASSIGNED
I'm done with week2 updates in the user story.
User Story: (updated)
Hey Chris or Luke, I need to test this list update (it feeds the service from https://github.com/mozilla-services/shavar-plugin-blocklist), but I don't know how this update can be published to staging without it automatically riding to production afterwards. Any ideas?
Flags: needinfo?(lcrouch)
Flags: needinfo?(ckolos)
Is this an update to the *content* of the list, or a new list altogether?
Flags: needinfo?(lcrouch)
Flags: needinfo?(ckolos)
List content.
Ok, I created a Pull Request with this update for week 2, and added a comment asking for it to not be merged to prod yet.

https://github.com/mozilla-services/shavar-plugin-blocklist/pull/10

Benjamin, a couple of the URLs requested to be added here were already on the list (https://github.com/mozilla-services/shavar-plugin-blocklist/blob/master/flashsubdoc.txt).

They are:
youtube.com/
pictela.net/
2mdn.net/
accounts.google.com/
andxs.com/
adap.tv/
doubleclick.net/
googlesyndication.com/
accounts.google.com/
ok. Because of the test-waiting issue I couldn't separate out the users who had list updates and those that didn't.
Current status: something is not working with the staging server, trying to figure it out before sending this over to QA.
Alright, the server prob has been fixed now. It was an expired cert for the staging server. I'm writing down QA instructions for Stefan.
Stefan, this is ready to be tested. Here are the instructions:
https://gist.github.com/felipc/96b3122fc40697088505cfa4eabc097c
Flags: needinfo?(stefan.georgiev)
We have tested the new list of blocked pages for Flash Experiment Week 2. Currently we covered Windows 7/10, Ubuntu 16.04 and OS X 10.12 (Sierra). All facebook games are running correctly and we did see the infobar pops-up asking to allow flash.

Sometimes page showed both the infobar and the gray plugin placeholder.

On regular facebook we did not see the infobar.

All top websites are working properly.
Youtube videos are CTP if videos are opened from 3-rd party website.
Flags: needinfo?(stefan.georgiev)
From a screenshot that Stefan sent me, the case when both the infobar and the gray box showed up, it was a plain gray box, and apparently not our placeholder. So I believe it has something to do with the website trying to detect Flash. In any case, we can keep an eye on other reports from it but I don't think it's a problem.

Given that Facebook games are working correctly, I'll go ahead and ask for the week 2 update to be pushed to prod.
This has been merged to production: https://github.com/mozilla-services/shavar-plugin-blocklist/pull/10
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.