Closed
Bug 1363857
Opened 7 years ago
Closed 7 years ago
Build with --enable-av1 fails on macOS in FFmpegLibWrapper
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: rillian, Assigned: rillian)
Details
Attachments
(1 file)
Building with --enable-av1 on mac I get the following error:
> In file included from /Users/giles/firefox/obj-x86_64-apple-darwin16.5.0/dom/media/platforms/Unified_cpp_dom_media_platforms1.cpp:2:
> In file included from /Users/giles/firefox/dom/media/platforms/ffmpeg/FFmpegLibWrapper.cpp:5:
> /Users/giles/firefox/dom/media/platforms/ffmpeg/FFmpegLibWrapper.h:24:19: error: incomplete type in call to object of type 'struct MOZ_ONLY_USED_TO_AVOID_STATIC_CONSTRUCTORS'
> FFmpegLibWrapper() = default;
> ~~~~~~~~~~~~~~~~^
> /Users/giles/firefox/dom/media/platforms/ffmpeg/FFmpegLibWrapper.h:21:8: note: forward declaration of 'mozilla::MOZ_ONLY_USED_TO_AVOID_STATIC_CONSTRUCTORS'
> struct MOZ_ONLY_USED_TO_AVOID_STATIC_CONSTRUCTORS FFmpegLibWrapper
> ^
|
Assignee | |
Comment 1•7 years ago
|
||
I think this is just the new source file changing the distribution of unified build side-effects. The file compiles if I add the missing mozilla/Attributes.h and PlatformDecoderModule.h includes.
Assignee: nobody → giles
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Summary: Build with --enable-av1 fails on macOS fails in FFmpegLibWrapper → Build with --enable-av1 fails on macOS in FFmpegLibWrapper
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8866570 [details] Bug 1363857 - Add missing includes to FFmpegLibWrapper. https://reviewboard.mozilla.org/r/138174/#review142342
Attachment #8866570 -
Flags: review?(gsquelart) → review+
Pushed by rgiles@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0902b42b1c55 Add missing includes to FFmpegLibWrapper. r=gerald
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0902b42b1c55
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•