Closed Bug 1363956 Opened 4 years ago Closed 4 years ago

Check the flag before calling expensive IsWindowProxy() in CheckedUnwrap()

Categories

(Core :: XPConnect, defect, P2)

Product:
Core
Component:
XPConnect
Platform:
All
Unspecified
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: ting, Assigned: ting)

References

(Blocks 1 open bug)

Details

(Whiteboard: [qf])

Attachments

(1 file)

Bug 1363956 - Check the flag before calling relatively expensive IsWindowProxy().
59 bytes, text/x-review-board-request
bzbarsky
: review+
Details 
From the profile of test case attachment 8848224 [details], I see IsWindowProxy() under CheckedUnwrap() which is form GenericBindingGetter(), it can be avoid by checking |stopAtWindowProxy| at first.
Priority: -- → P2
Whiteboard: [qf]
Comment on attachment 8866615 [details]
Bug 1363956 - Check the flag before calling relatively expensive IsWindowProxy().

https://reviewboard.mozilla.org/r/138220/#review141884

::: commit-message-0b255:1
(Diff revision 1)
> +Bug 1363956 - Check the flag before calling expensive IsWindowProxy(). r?bz

How about:

  Check the stopAtWindowProxy flag before checking IsWindowProxy(), since the flag check is cheaper and in performance-sensitive binding code the flag is false.
  
for the commit message?
Attachment #8866615 - Flags: review?(bzbarsky) → review+
Comment on attachment 8866615 [details]
Bug 1363956 - Check the flag before calling relatively expensive IsWindowProxy().

https://reviewboard.mozilla.org/r/138220/#review141884

> How about:
> 
>   Check the stopAtWindowProxy flag before checking IsWindowProxy(), since the flag check is cheaper and in performance-sensitive binding code the flag is false.
>   
> for the commit message?

Added. I was kind of nervous because of your nick, the patch is straitghtforward which I didn't know how to make a more decent message, I've learned and thanks about that.
Pushed by tchou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e1bb35dd44fc
Check the flag before calling relatively expensive IsWindowProxy(). r=bz
Assignee: nobody → janus926
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/e1bb35dd44fc
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.