1363961 - stylo: AttrHasSubstring gets its strings backwards

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

We're doing:

  return FindInReadable(str, nsDependentAtomString(aStr));

where "str" is the attr value and "aStr" comes from the selector.

But FindInReadable takes the pattern as the first arg, the string to search within as the second arg.  So the args are backwards.

Patch coming up once I have try results indicating which tests start passing with this fixed.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix the order of arguments to FindInReadable in AttrHasSubstring

MozReview-Commit-ID: BAsd9bN4dtA

Comment 2

[Bobby Holley (:bholley)]

Nice find!

Comment 3

[Boris Zbarsky [:bzbarsky]]

Manish found this; it was in his list of unknown failures.  ;)

I'm also adding some tests to test_selectors.html for this.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/990b66f0c7e8
Fix the order of arguments to FindInReadable in AttrHasSubstring.  r=heycam

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/990b66f0c7e8