Closed Bug 1363970 Opened 7 years ago Closed 5 years ago

Color picker doesn't work/move in RDM, when touch is enabled.

Categories

(DevTools :: Responsive Design Mode, defect, P2)

Product:
DevTools
Component:
Responsive Design Mode
Version:
53 Branch
Platform:
All
Unspecified
Type:
defect

Tracking

(firefox57 wontfix, firefox71 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 71
Tracking Flags:
Tracking Status
firefox57 --- wontfix
firefox71 --- verified

People

(Reporter: dehghani.m.c, Assigned: mtigley)

References

(Blocks 1 open bug)

Details

(Whiteboard: [dt-q])

Attachments

(1 file)

Bug 1363970 - Disable touch simulation when color picker is active.
47 bytes, text/x-phabricator-request
Details | Review 
Hello,

FF 53.0.2
e10s: enabled
Windows: 10 x64

In new RDM, when touch simulation is enabled, the Inspector's color picker doesn't move (lock in somewhere in the screen), but after toggling touch simulation (turn that off) it works again.

Mehdi
See Also: → 1390103
Thanks for the report!  I can reproduce the issue.
status-firefox57: --- → fix-optional
Priority: -- → P2
See Also: 1390103 →
Product: Firefox → DevTools
It also dont work when you resize the screen.
See Also: → 1533976
Whiteboard: [dt-q]
Assignee: nobody → mtigley
Status: NEW → ASSIGNED

Since we're picking from the page while RDM's touch simulation is active, it's likely the touch-simulator will need to bail out before the touch event is handled. This would be the same approach done for Bug 1409085.

If that's the case we'll need to tell RDM to disable touch events depending on the color picker state.

Places where the color picker is being enabled: https://dxr.mozilla.org/mozilla-central/search?q=pickColorFromPa&redirect=false

Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/570912314438
Disable touch simulation when color picker is active. r=gl,rcaliman

https://hg.mozilla.org/mozilla-central/rev/570912314438

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Flags: qe-verify+

Confirmed issue with 58.0a1 (2017-10-26) on Windows 10.
Verified fix with 71.0b5 on Windows 10, Ubuntu 18.04 and 71.0b3 on macOS 10.14.

Status: RESOLVED → VERIFIED
status-firefox71: fixed → verified
Flags: qe-verify+
Hardware: Unspecified → All
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: