Closed Bug 1363972 Opened 8 years ago Closed 8 years ago

I can make a web request to the API to construct a phabrictator revision (with stub revision data) in the staging repo

Categories

(Conduit :: General, enhancement)

Product:
Conduit
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: zalun, Unassigned)

References

(
URL
)

Details

lando-api **AC** - No validation that the user can see the phabricator revision (500 if they can't) - No validation that the user has right SCM level to land in repo (everyone can land) - Swagger definition for "land it!" method (use client-driven contract from lando-ui if possible) - call hg pull before constructing commit (return 500 if conflict or other error, jams system) - always constructs same blank commit in repo, "hello world! Revision someID" as message - repo to land into is configurable
Outdated, this work is not needed. Lando API will delegate constructing commits to the transplant service.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.