1363994 - isAdaptivePlaybackSupported method should have the same implementation in LollipopAsyncCodec and JellyBeanAsyncCodec

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Audio/Video, enhancement)

Description

[James Cheng[:JamesCheng]]

I found these two implementation are different,
Lollipop
http://searchfox.org/mozilla-central/rev/d66b9f27d5630a90b2fce4d70d4e9050f43df9b4/mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/LollipopAsyncCodec.java#143


JellyBeanAsyncCodec
http://searchfox.org/mozilla-central/rev/d66b9f27d5630a90b2fce4d70d4e9050f43df9b4/mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/JellyBeanAsyncCodec.java#308

They should be identical since we used blacklist to filter out some specific devices[1].

[1]
http://searchfox.org/mozilla-central/rev/d66b9f27d5630a90b2fce4d70d4e9050f43df9b4/mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/HardwareCodecCapabilityUtils.java#94

Comment 1

[James Cheng[:JamesCheng]]

Attachment: Bug 1363994 - Use the same implementation of isAdaptivePlaybackSupported in LollipopAsyncCodec and JellyBeanAsyncCodec

Review commit: https://reviewboard.mozilla.org/r/138288/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/138288/

Comment 2

[John Lin [:jhlin][:jolin]]

Comment on attachment 8866680 [details]
Bug 1363994 - Use the same implementation of isAdaptivePlaybackSupported in LollipopAsyncCodec and JellyBeanAsyncCodec

https://reviewboard.mozilla.org/r/138288/#review141462

LGTM. Thanks a lot!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/efa396c0645f
Use the same implementation of isAdaptivePlaybackSupported in LollipopAsyncCodec and JellyBeanAsyncCodec r=jolin

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/efa396c0645f