Closed
Bug 1363994
Opened 7 years ago
Closed 7 years ago
isAdaptivePlaybackSupported method should have the same implementation in LollipopAsyncCodec and JellyBeanAsyncCodec
Categories
(Firefox for Android Graveyard :: Audio/Video, enhancement)
Firefox for Android Graveyard
Audio/Video
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: JamesCheng, Assigned: JamesCheng)
Details
Attachments
(1 file)
I found these two implementation are different, Lollipop http://searchfox.org/mozilla-central/rev/d66b9f27d5630a90b2fce4d70d4e9050f43df9b4/mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/LollipopAsyncCodec.java#143 JellyBeanAsyncCodec http://searchfox.org/mozilla-central/rev/d66b9f27d5630a90b2fce4d70d4e9050f43df9b4/mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/JellyBeanAsyncCodec.java#308 They should be identical since we used blacklist to filter out some specific devices[1]. [1] http://searchfox.org/mozilla-central/rev/d66b9f27d5630a90b2fce4d70d4e9050f43df9b4/mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/HardwareCodecCapabilityUtils.java#94
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8866680 -
Flags: review?(jolin)
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8866680 [details] Bug 1363994 - Use the same implementation of isAdaptivePlaybackSupported in LollipopAsyncCodec and JellyBeanAsyncCodec https://reviewboard.mozilla.org/r/138288/#review141462 LGTM. Thanks a lot!
Attachment #8866680 -
Flags: review?(jolin) → review+
Pushed by jacheng@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/efa396c0645f Use the same implementation of isAdaptivePlaybackSupported in LollipopAsyncCodec and JellyBeanAsyncCodec r=jolin
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/efa396c0645f
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•