Closed Bug 1364023 Opened 3 years ago Closed 3 years ago

Remove LOCALE_SNAME define for ICU build

Categories

(Core :: JavaScript: Internationalization API, enhancement)

55 Branch
Unspecified
Windows
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file)

There is a lot of LOCALE_SNAME redefine warning after we move to WINVER=601.  It is unnecessary to define this into moz.build.


17:31:29     INFO -  c:\builds\moz2_slave\m-cen-w32-00000000000000000000\build\src\vs2015u3\SDK\Include\10.0.14393.0\um\winnls.h(665): warning C4005: 'LOCALE_SNAME': macro redefinition
17:31:29     INFO -  c:\builds\moz2_slave\m-cen-w32-00000000000000000000\build\src\vs2015u3\SDK\Include\10.0.14393.0\um\winnls.h(665): note: command-line arguments:  see previous definition of 'LOCALE_SNAME'
17:31:29     INFO -  c:/builds/moz2_slave/m-cen-w32-00000000000000000000/build/src/obj-firefox/_virtualenv/Scripts/python.exe -m mozbuild.action.cl  c:/builds/moz2_slave/m-cen-w32-00000000000000000000/build/src/vs2015u3/VC/bin/amd64_x86/cl.exe -Foe_sinh.obj -c -Ic:/builds/moz2_slave/m-cen-w32-00000000000000000000/build/src/obj-firefox/dist/stl_wrappers  -DNDEBUG=1 -DTRIMMED=1 -DMOZ_HAS_MOZGLUE -Ic:/builds/moz2_slave/m-cen-w32-00000000000000000000/build/src/modules/fdlibm/src -Ic:/builds/moz2_slave/m-cen-w32-00000000000000000000/build/src/obj-firefox/modules/fdlibm/src  -Ic:/builds/moz2_slave/m-cen-w32-00000000000000000000/build/src/obj-firefox/dist/include  -Ic:/builds/moz2_slave/m-cen-w32-00000000000000000000/build/src/obj-firefox/dist/include/nspr -Ic:/builds/moz2_slave/m-cen-w32-00000000000000000000/build/src/obj-firefox/dist/include/nss        -MD -FI c:/builds/moz2_slave/m-cen-w32-00000000000000000000/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT   -TP -nologo -wd5026 -wd5027 
...
Comment on attachment 8866713 [details] [diff] [review]
Remove unnecessary LOCALE_SNAME define from moz.build

Since we set WINVER=601 after dropping Windows XP support, it is unnecessary to define LOCALE_SNAME.  So, we should remove it to remove compiler warning.
Attachment #8866713 - Flags: review?(mh+mozilla)
Comment on attachment 8866713 [details] [diff] [review]
Remove unnecessary LOCALE_SNAME define from moz.build

Review of attachment 8866713 [details] [diff] [review]:
-----------------------------------------------------------------

Please put the justification from comment 2 in the commit message.
Attachment #8866713 - Flags: review?(mh+mozilla) → review+
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d990834b3e4
Remove LOCALE_SNAME define for ICU build. r=glandium
https://hg.mozilla.org/mozilla-central/rev/5d990834b3e4
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.