If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

bugfiler.tests.js is failing in 'BugFilerCtrl should parse summaries'

RESOLVED FIXED

Status

Tree Management
Treeherder
P1
normal
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: emorley, Assigned: KWierso)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

4 months ago
"""
Firefox 53.0.0 (Linux 0.0.0) displayNumber filter returns expected values FAILED
	Expected '∞' to equal 'Infinity'.
	@tests/ui/unit/init.js:158122:9
Firefox 53.0.0 (Linux 0.0.0): Executed 31 of 44 (2 FAILED) (0 secs / 0.863 secs)
Firefox 53.0.0 (Linux 0.0.0) displayNumber filter returns expected values FAILED
	Expected '∞' to equal 'Infinity'.
	@tests/ui/unit/init.js:158122:9
"""

https://travis-ci.org/mozilla/treeherder/jobs/230892456#L386

The Travis job is currently green even though the test is failing, due to bug 1364030.

This testcase was added in bug 1356719.

Wes, don't suppose you could take a look? :-)
Flags: needinfo?(wkocher)
(Assignee)

Comment 1

4 months ago
Clearing NI request since I won't be around for a week. I'll take a look when I get back, though.
Assignee: nobody → wkocher
Flags: needinfo?(wkocher)
(Assignee)

Updated

3 months ago
Flags: needinfo?(wkocher)
(Reporter)

Comment 2

3 months ago
We now have a fix for Neutrino test reporting the tests as passing in bug 1364030, so we're going to need to green up the failing tests asap.

Wes, any chance you could look at this in the next 24 hours? :-)
(Reporter)

Comment 3

3 months ago
Oh and my log copy-paste from comment 0 should have read:
```
Firefox 53.0.0 (Linux 0.0.0) BugFilerCtrl should parse summaries FAILED
	Expected 'layout/reftests/backgrounds/vector/empty/wide--cover--width.html == layout/reftests/backgrounds/vector/empty/ref-wide-lime.html' to be 'backgrounds/vector/empty/wide--cover--width.html == backgrounds/vector/empty/ref-wide-lime.html'.
	@tests/ui/unit/init.js:157769:5
	ContextKarma/this.loaded@http://localhost:9876/context.js:151:7
	Expected 'TEST-UNEXPECTED-PASS' to be 'display-contents-style-inheritance-1.html'.
	@tests/ui/unit/init.js:157771:5
	ContextKarma/this.loaded@http://localhost:9876/context.js:151:7
```

Since then these tests have broken further from bug 1355339 landing:

```
Firefox 54.0.0 (Linux 0.0.0) BugFilerCtrl should parse summaries FAILED
	Error: [$injector:unpr] Unknown provider: search_termsProvider <- search_terms <- BugFilerCtrl
	http://errors.angularjs.org/1.5.11/$injector/unpr?p0=search_termsProvider%20%3C-%20search_terms%20%3C-%20BugFilerCtrl
	...
	TypeError: bugFilerScope.parseSummary is not a function in tests/ui/unit/init.js (line 161060)

```

(The `search_terms` provider needs to be added to the tests too.)
Blocks: 1355339

Comment 4

3 months ago
Created attachment 8879359 [details] [review]
[treeherder] KWierso:fixtests > mozilla:master
(Assignee)

Comment 5

3 months ago
Comment on attachment 8879359 [details] [review]
[treeherder] KWierso:fixtests > mozilla:master

Fixed the missing search_terms provider. One of the tests was actually checking the wrong thing, while simultaneously being provided the wrong string from the non-test function in the case where there's a "TEST-UNEXPECTED-PASS" in the failure summary. This should fix all of those things.
Flags: needinfo?(wkocher)
Attachment #8879359 - Flags: review?(emorley)
(Reporter)

Comment 6

3 months ago
Comment on attachment 8879359 [details] [review]
[treeherder] KWierso:fixtests > mozilla:master

Great work, thank you!
Attachment #8879359 - Flags: review?(emorley) → review+

Comment 7

3 months ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/9ff824aa98f4f7b92ecc081c55814ab71fdb2c6f
Bug 1364033 - Fix test failures in BugFilerCtrl (#2581)

Fix missing search_terms in test
Fix a broken test and a broken findFilename() function
(Reporter)

Updated

3 months ago
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.