Closed Bug 1364089 Opened 5 years ago Closed 5 years ago

Remove unnecessary virtual method calls in gfxFont/gfxFontGroup code

Categories

(Core :: Graphics: Text, enhancement)

Product:
Core
Component:
Graphics: Text
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: jfkthame, Assigned: jfkthame)

References

Details

Attachments

(1 file)

Eliminate some unnecessary virtual calls in gfxFont-related code
9.37 KB, patch
jrmuizel
: review+
Details | Diff | Splinter Review 
Since the removal of the old fontconfig backend in bug 1285533, we no longer have any subclasses of gfxFontGroup, so various of its methods don't need to be virtual; similarly, there are a few methods in gfxFont and gfxFontEntry that no longer have any overrides and can be made non-virtual.
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Attachment #8866823 - Flags: review?(jmuizelaar) → review+
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc7327ab555a
Eliminate some unnecessary virtual calls in gfxFont-related code. r=jrmuizel
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc7327ab555ab30167e81d9201c046ca8baf797f
Bug 1364089 - Eliminate some unnecessary virtual calls in gfxFont-related code. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/dc7327ab555a
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.