Remove unnecessary virtual method calls in gfxFont/gfxFontGroup code

RESOLVED FIXED in Firefox 55

Status

()

Core
Graphics: Text
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: jfkthame, Assigned: jfkthame)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 months ago
Since the removal of the old fontconfig backend in bug 1285533, we no longer have any subclasses of gfxFontGroup, so various of its methods don't need to be virtual; similarly, there are a few methods in gfxFont and gfxFontEntry that no longer have any overrides and can be made non-virtual.
(Assignee)

Comment 1

9 months ago
Created attachment 8866823 [details] [diff] [review]
Eliminate some unnecessary virtual calls in gfxFont-related code
Attachment #8866823 - Flags: review?(jmuizelaar)
(Assignee)

Updated

9 months ago
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Attachment #8866823 - Flags: review?(jmuizelaar) → review+

Comment 2

9 months ago
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc7327ab555a
Eliminate some unnecessary virtual calls in gfxFont-related code. r=jrmuizel
(Assignee)

Comment 3

9 months ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc7327ab555ab30167e81d9201c046ca8baf797f
Bug 1364089 - Eliminate some unnecessary virtual calls in gfxFont-related code. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/dc7327ab555a
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.