Remove unnecessary virtual method calls in gfxFont/gfxFontGroup code

RESOLVED FIXED in Firefox 55

Status

()

Product:
Core
Component:
Graphics: Text
Type:
enhancement
Status:
RESOLVED FIXED
Reported:
2 years ago
Modified:
2 years ago

People

(Reporter: jfkthame, Assigned: jfkthame)

Tracking

Version:
unspecified
Target:
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

Eliminate some unnecessary virtual calls in gfxFont-related code
9.37 KB, patch
jrmuizel
: review+
Details | Diff | Splinter Review
Assignee

Description

•
2 years ago 
Since the removal of the old fontconfig backend in bug 1285533, we no longer have any subclasses of gfxFontGroup, so various of its methods don't need to be virtual; similarly, there are a few methods in gfxFont and gfxFontEntry that no longer have any overrides and can be made non-virtual.
 Assignee

Updated

•
2 years ago
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Attachment #8866823 - Flags: review?(jmuizelaar) → review+

Comment 2

•
2 years ago 
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc7327ab555a
Eliminate some unnecessary virtual calls in gfxFont-related code. r=jrmuizel
 Assignee

Comment 3

•
2 years ago 
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc7327ab555ab30167e81d9201c046ca8baf797f
Bug 1364089 - Eliminate some unnecessary virtual calls in gfxFont-related code. r=jrmuizel

Comment 4

•
2 years ago
bugherder 
https://hg.mozilla.org/mozilla-central/rev/dc7327ab555a
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.