ANGLE contexts request robustness but do not get it

RESOLVED FIXED in Firefox 55

Status

()

enhancement
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: svargas, Assigned: svargas, Mentored)

Tracking

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: gfx-noted)

Attachments

(1 attachment, 2 obsolete attachments)

Comment hidden (empty)
Comment on attachment 8866891 [details] [diff] [review]
0001-Bug-1364169-on-ANGLE-context-creation-asks-for-robus.patch

Review of attachment 8866891 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/angle/src/libANGLE/Context.cpp
@@ +166,5 @@
> +	{
> +		attrib = EGL_NO_RESET_NOTIFICATION;
> +	}
> +
> +	return attrib;

We actually still need the switch, because we need to convert between the EGL_ enums here, and the GL_ enums this function is supposed to return. (and the EGL_ and GL_ values differ)
Attachment #8866891 - Flags: review?(jgilbert) → review-
(Assignee)

Comment 3

2 years ago
Attachment #8866891 - Attachment is obsolete: true
Attachment #8866923 - Flags: review?(jgilbert)
Comment on attachment 8866923 [details] [diff] [review]
0001-Bug-1364169-on-ANGLE-context-creation-asks-for-robus.patch

Review of attachment 8866923 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/angle/src/libANGLE/Context.cpp
@@ +157,4 @@
>  
>  GLenum GetResetStrategy(const egl::AttributeMap &attribs)
>  {
> +	EGLAttrib attrib = attribs.get(EGL_CONTEXT_OPENGL_RESET_NOTIFICATION_STRATEGY_KHR, 0);

These are tabs for some reason!
Attachment #8866923 - Flags: review?(jgilbert) → review-
(Assignee)

Comment 5

2 years ago
Attachment #8866923 - Attachment is obsolete: true
Attachment #8866928 - Flags: review?(jgilbert)
Attachment #8866928 - Flags: review?(jgilbert) → review+
Assignee: nobody → svargas
Priority: -- → P1
Whiteboard: gfx-noted
For future reference, please try to use commit messages that summarize what the patch is actually doing rather than restating the problem being fixed. Thanks!

Comment 7

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a7dc86b21aa5
On ANGLE context creation asks for robustness but does not get it. r=jgilbert
Keywords: checkin-needed

Comment 9

2 years ago
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/74b2d6cfaee3
on ANGLE context creation asks for robustness but does not get it - r=jgilbert
Depends on: 1365067
Summary: on ANGLE context creation asks for robustness but does not get it → ANGLE contexts request robustness but do not get it
Blocks: 1366425

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/74b2d6cfaee3
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
(Assignee)

Comment 11

2 years ago
Clearning now redundant need info..
Flags: needinfo?(svargas)
You need to log in before you can comment on or make changes to this bug.