1364264 - stylo: Check ElementHasAnimations before calling Gecko_ElementHasAnimations

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Hiroyuki Ikezoe (:hiro)]

After landing bug 1361183, we still see Gecko_ElementHasAnimations in a profile in bug 1360889 comment 5 [1], especially nsCSSPseudoElements::GetPseudoType.

And I noticed that we can check ElementHasAnimations in Rust. We should do it.

[1] https://perf-html.io/public/b648ad4c479ab33995bc1545ad4058d3e85c3eef/calltree/?callTreeFilters=prefix-0123456789abcdeBngyYfzIrjkzJ8mnzJ0xDtxwsxDvxE0xE1xE2xE3xE4xE5xE6xE7~prefix-xE7xHhxE9xEnxEs&thread=0

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd803967804eac2060f48d106f54c87263f9b72a

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1364264 - Check ElementHasAnimations flag in rust side.

We can bail out earlier before calling an FFI function.

Review commit: https://reviewboard.mozilla.org/r/138618/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/138618/

Comment 2

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Comment on attachment 8867013 [details]
Bug 1364264 - Check ElementHasAnimations flag in rust side.

https://reviewboard.mozilla.org/r/138618/#review141882

Nice!

::: servo/components/style/gecko/wrapper.rs:412
(Diff revision 1)
>          }
>      }
> +
> +    fn may_have_animations(&self) -> bool {
> +        use gecko_bindings::structs::nsINode_BooleanFlag;
> +        self.as_node().bool_flags() & (1u32 << nsINode_BooleanFlag::ElementHasAnimations as u32) != 0

Nit: This line appears to be > 100 chars

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Thank you for the review!

https://github.com/servo/servo/pull/16826

Comment 4

[Hiroyuki Ikezoe (:hiro)]

https://hg.mozilla.org/integration/autoland/rev/2c47afd31dd132c9478a3e520ef02f55c53434ef