1364287 - Fix SM shell tsan failures in OSObject.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Steve Fink [:sfink] [:s:]]

Up until now, we've kept js.cpp very self-contained, and it's grown into a monstrosity. shell/OSObject.cpp tries to split off some stuff, but it ran into the monolithic nature. So I moved ShellContext into a header file so that I can store some state there instead of in global variables.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Move g{Out,Err}FilePtr into ShellContext for thread safety

This isn't just a thread safety fix. Before this, you actually had multiple threads sharing these output files, and if more than one thread ever decided to change them, you would get a complete mess. Per-context values make much more sense than per-process.

Comment 2

[Jon Coppeard (:jonco)]

Comment on attachment 8867032 [details] [diff] [review]
Move g{Out,Err}FilePtr into ShellContext for thread safety

Review of attachment 8867032 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c5aadffcf7c
Move g{Out,Err}FilePtr into ShellContext for thread safety, r=jonco

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7c5aadffcf7c