Closed
Bug 1364334
Opened 7 years ago
Closed 7 years ago
Rename formautofill preference prefix and address pref suffix
Categories
(Toolkit :: Form Manager, enhancement)
Toolkit
Form Manager
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: MattN, Assigned: MattN)
Details
(Whiteboard: [form autofill:M2])
Attachments
(2 files)
Since eventually formautofill code may be used on Android and the convention for system add-ons is to use the "extensions." pref namespace I think we should rename our preferences to also use that same prefix. Also, since we are starting implementation on credit card autofill, we should rename "browser.formautofill.enabled" to "extensions.formautofill.addresses.enabled" since there will be a separate toggle for credit cards which can be "extensions.formautofill.creditCards.enabled"
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Whiteboard: [form autofill:M2]
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8867058 [details] Bug 1364334 - Rename "browser.formautofill.enabled" pref to "extensions.formautofill.addresses.enabled". https://reviewboard.mozilla.org/r/138682/#review141918
Attachment #8867058 -
Flags: review?(lchang) → review+
|
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8867059 [details] Bug 1364334 - Rename "browser.formautofill.*" prefs to "extensions.formautofill.*". https://reviewboard.mozilla.org/r/138684/#review141920
Attachment #8867059 -
Flags: review?(lchang) → review+
|
|
||
Comment 5•7 years ago
|
||
Yeah, that makes sense. Thanks.
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/01a8daf0776f Rename "browser.formautofill.enabled" pref to "extensions.formautofill.addresses.enabled". r=lchang https://hg.mozilla.org/integration/autoland/rev/bcb5e1ff13f8 Rename "browser.formautofill.*" prefs to "extensions.formautofill.*". r=lchang
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/01a8daf0776f https://hg.mozilla.org/mozilla-central/rev/bcb5e1ff13f8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•