Remove unused filterClear function

RESOLVED FIXED in Firefox 55

Status

DevTools
Console
P1
normal
RESOLVED FIXED
a year ago
12 days ago

People

(Reporter: nchevobbe, Assigned: bgrins)

Tracking

unspecified
Firefox 55
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [console-html])

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a year ago
The action is only dispatched in a function : http://searchfox.org/mozilla-central/search?q=onClickFiltersClear&case=false&regexp=false&path= which is never called.
I don't remember what was the original idea of this, but I think we can remove it for now since it's unused.
(Reporter)

Updated

a year ago
Flags: qe-verify-
Priority: -- → P2
Whiteboard: [console-html]
(Assignee)

Comment 1

a year ago
Going to just remove this from the components file for now, since it's used to reset state in the test files as well
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Iteration: --- → 55.6 - May 29
Priority: P2 → P1
Comment hidden (mozreview-request)
(Reporter)

Comment 3

a year ago
mozreview-review
Comment on attachment 8869106 [details]
Bug 1364353 - Remove unused onClickFiltersClear function;

https://reviewboard.mozilla.org/r/140732/#review144334

Small and nice !
Attachment #8869106 - Flags: review?(nchevobbe) → review+
(Reporter)

Comment 4

a year ago
mozreview-review
Comment on attachment 8869106 [details]
Bug 1364353 - Remove unused onClickFiltersClear function;

https://reviewboard.mozilla.org/r/140732/#review144336

Comment 5

a year ago
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/10c052ccf90c
Remove unused onClickFiltersClear function;r=nchevobbe

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/10c052ccf90c
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55

Updated

12 days ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.