Closed Bug 1364353 Opened 2 years ago Closed 2 years ago

Remove unused filterClear function

Categories

(DevTools :: Console, enhancement, P1)

enhancement

Tracking

(firefox55 fixed)

RESOLVED FIXED
Firefox 55
Iteration:
55.6 - May 29
Tracking Status
firefox55 --- fixed

People

(Reporter: nchevobbe, Assigned: bgrins)

Details

(Whiteboard: [console-html])

Attachments

(1 file)

The action is only dispatched in a function : http://searchfox.org/mozilla-central/search?q=onClickFiltersClear&case=false&regexp=false&path= which is never called.
I don't remember what was the original idea of this, but I think we can remove it for now since it's unused.
Flags: qe-verify-
Priority: -- → P2
Whiteboard: [console-html]
Going to just remove this from the components file for now, since it's used to reset state in the test files as well
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Iteration: --- → 55.6 - May 29
Priority: P2 → P1
Comment on attachment 8869106 [details]
Bug 1364353 - Remove unused onClickFiltersClear function;

https://reviewboard.mozilla.org/r/140732/#review144334

Small and nice !
Attachment #8869106 - Flags: review?(nchevobbe) → review+
Comment on attachment 8869106 [details]
Bug 1364353 - Remove unused onClickFiltersClear function;

https://reviewboard.mozilla.org/r/140732/#review144336
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/10c052ccf90c
Remove unused onClickFiltersClear function;r=nchevobbe
https://hg.mozilla.org/mozilla-central/rev/10c052ccf90c
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.