1364353 - Remove unused filterClear function

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

The action is only dispatched in a function : http://searchfox.org/mozilla-central/search?q=onClickFiltersClear&case=false&regexp=false&path= which is never called.
I don't remember what was the original idea of this, but I think we can remove it for now since it's unused.

Comment 1

[Brian Grinstead [:bgrins]]

Going to just remove this from the components file for now, since it's used to reset state in the test files as well

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: Bug 1364353 - Remove unused onClickFiltersClear function;

Review commit: https://reviewboard.mozilla.org/r/140732/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/140732/

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8869106 [details]
Bug 1364353 - Remove unused onClickFiltersClear function;

https://reviewboard.mozilla.org/r/140732/#review144334

Small and nice !

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8869106 [details]
Bug 1364353 - Remove unused onClickFiltersClear function;

https://reviewboard.mozilla.org/r/140732/#review144336

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10c052ccf90c
Remove unused onClickFiltersClear function;r=nchevobbe

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/10c052ccf90c