Drop unused -DMOZ_RUST_MP4PARSE from old-configure.in

RESOLVED FIXED in Firefox 55

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jbeich, Assigned: jbeich)

Tracking

Trunk
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fix-optional, firefox55 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

$ git grep -F MOZ_RUST_MP4PARSE
old-configure.in:if test -n "$MOZ_RUST_MP4PARSE"; then
old-configure.in:    AC_DEFINE(MOZ_RUST_MP4PARSE)

$ git grep -F MOZ_RUST_MP4PARSE origin/beta
origin/beta:old-configure.in:    if test -n "$MOZ_RUST_MP4PARSE"; then
origin/beta:old-configure.in:        AC_DEFINE(MOZ_RUST_MP4PARSE)
Posted patch rebased for ff54 (obsolete) — Splinter Review
Attachment #8867161 - Flags: approval-mozilla-beta?
Attachment #8867161 - Flags: approval-mozilla-beta?
(In reply to Jan Beich from comment #2)
> Created attachment 8867161 [details] [diff] [review]
> rebased for ff54

I assume this was a mistake? Is there a reason this cleanup needs to be uplifted?
Comment on attachment 8867153 [details]
Bug 1364422 - Drop unused -DMOZ_RUST_MP4PARSE after bug 1341967.

https://reviewboard.mozilla.org/r/138748/#review142124

Good catch, thanks!

Note you should really run '-u gtest' on try to confirm rust or mp4parse changes are working. I've added a job to your current try push for this.
Attachment #8867153 - Flags: review?(giles) → review+
Can we remove MOZ_RUST_URLPARSE as well?
Comment on attachment 8867161 [details] [diff] [review]
rebased for ff54

(In reply to Ralph Giles (:rillian) | needinfo me from comment #3)
> I assume this was a mistake? Is there a reason this cleanup needs to be uplifted?

None except more clarity. ;)

(In reply to Ralph Giles (:rillian) | needinfo me from comment #5)
> Can we remove MOZ_RUST_URLPARSE as well?

Probably not until it's ready to ride release trains.

http://searchfox.org/mozilla-central/rev/cd8c561106d8/browser/confvars.sh#33
Attachment #8867161 - Attachment is obsolete: true
Comment on attachment 8867153 [details]
Bug 1364422 - Drop unused -DMOZ_RUST_MP4PARSE after bug 1341967.

https://reviewboard.mozilla.org/r/138748/#review142124

Thanks. I have only level 1 access which doesn't allow adding/restarting jobs.
(In reply to Jan Beich from comment #6)

> > Can we remove MOZ_RUST_URLPARSE as well?
> 
> Probably not until it's ready to ride release trains.

Ah, right. Thanks for checking.
Assignee: nobody → jbeich
Pushed by rgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c1848288f699
Drop unused -DMOZ_RUST_MP4PARSE after bug 1341967. r=rillian
https://hg.mozilla.org/mozilla-central/rev/c1848288f699
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.