1364422 - Drop unused -DMOZ_RUST_MP4PARSE from old-configure.in

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Jan Beich]

$ git grep -F MOZ_RUST_MP4PARSE
old-configure.in:if test -n "$MOZ_RUST_MP4PARSE"; then
old-configure.in:    AC_DEFINE(MOZ_RUST_MP4PARSE)

$ git grep -F MOZ_RUST_MP4PARSE origin/beta
origin/beta:old-configure.in:    if test -n "$MOZ_RUST_MP4PARSE"; then
origin/beta:old-configure.in:        AC_DEFINE(MOZ_RUST_MP4PARSE)

Comment 1

[Jan Beich]

Attachment: Bug 1364422 - Drop unused -DMOZ_RUST_MP4PARSE after bug 1341967.

Review commit: https://reviewboard.mozilla.org/r/138748/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/138748/

Comment 2

[Jan Beich]

Attachment: rebased for ff54

Comment 3

[Ralph Giles (:rillian)]

(In reply to Jan Beich from comment #2)
> Created attachment 8867161 [details] [diff] [review]
> rebased for ff54

I assume this was a mistake? Is there a reason this cleanup needs to be uplifted?

Comment 4

[Ralph Giles (:rillian)]

Comment on attachment 8867153 [details]
Bug 1364422 - Drop unused -DMOZ_RUST_MP4PARSE after bug 1341967.

https://reviewboard.mozilla.org/r/138748/#review142124

Good catch, thanks!

Note you should really run '-u gtest' on try to confirm rust or mp4parse changes are working. I've added a job to your current try push for this.

Comment 5

[Ralph Giles (:rillian)]

Can we remove MOZ_RUST_URLPARSE as well?

Comment 6

[Jan Beich]

Comment on attachment 8867161 [details] [diff] [review]
rebased for ff54

(In reply to Ralph Giles (:rillian) | needinfo me from comment #3)
> I assume this was a mistake? Is there a reason this cleanup needs to be uplifted?

None except more clarity. ;)

(In reply to Ralph Giles (:rillian) | needinfo me from comment #5)
> Can we remove MOZ_RUST_URLPARSE as well?

Probably not until it's ready to ride release trains.

http://searchfox.org/mozilla-central/rev/cd8c561106d8/browser/confvars.sh#33

Comment 7

[Jan Beich]

Comment on attachment 8867153 [details]
Bug 1364422 - Drop unused -DMOZ_RUST_MP4PARSE after bug 1341967.

https://reviewboard.mozilla.org/r/138748/#review142124

Thanks. I have only level 1 access which doesn't allow adding/restarting jobs.

Comment 8

[Ralph Giles (:rillian)]

(In reply to Jan Beich from comment #6)

> > Can we remove MOZ_RUST_URLPARSE as well?
> 
> Probably not until it's ready to ride release trains.

Ah, right. Thanks for checking.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1848288f699
Drop unused -DMOZ_RUST_MP4PARSE after bug 1341967. r=rillian

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c1848288f699