1364445 - Add localization comment to 'More' string for static hamburger menu

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, enhancement, P1)

Description

[Francesco Lodolo [:flod]]

String landed in 
https://hg.mozilla.org/mozilla-central/diff/1e6c8eee951e/browser/locales/en-US/chrome/browser/browser.dtd

Without a localization comment and context it's extremely easy to get it wrong for localizer.

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Bug 1364445 - Add localization comment to moreMenu.label

Review commit: https://reviewboard.mozilla.org/r/138784/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/138784/

Comment 2

[Francesco Lodolo [:flod]]

Not completely sure if the comment is accurate, since the invision link is broken and the new build doesn't have this yet
https://mozilla.invisionapp.com/share/A7AFC1ZGW#/screens/218570316

Comment 3

[Mike de Boer [:mikedeboer]]

Comment on attachment 8867212 [details]
Bug 1364445 - Add localization comment to moreMenu.label

https://reviewboard.mozilla.org/r/138784/#review142108

It's appropriate! :) Thanks for jumping on this!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40ab96c6501c
Add localization comment to moreMenu.label r=mikedeboer

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/40ab96c6501c