Closed Bug 1364445 Opened 4 years ago Closed 4 years ago

Add localization comment to 'More' string for static hamburger menu

Categories

(Firefox :: Toolbars and Customization, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 55
Iteration:
55.5 - May 15
Tracking Status
firefox55 --- fixed

People

(Reporter: flod, Assigned: flod)

References

Details

(Whiteboard: [photon-structure])

Attachments

(1 file)

String landed in 
https://hg.mozilla.org/mozilla-central/diff/1e6c8eee951e/browser/locales/en-US/chrome/browser/browser.dtd

Without a localization comment and context it's extremely easy to get it wrong for localizer.
Status: NEW → ASSIGNED
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [photon-structure]
Not completely sure if the comment is accurate, since the invision link is broken and the new build doesn't have this yet
https://mozilla.invisionapp.com/share/A7AFC1ZGW#/screens/218570316
Comment on attachment 8867212 [details]
Bug 1364445 - Add localization comment to moreMenu.label

https://reviewboard.mozilla.org/r/138784/#review142108

It's appropriate! :) Thanks for jumping on this!
Attachment #8867212 - Flags: review?(mdeboer) → review+
Pushed by francesco.lodolo@mozillaitalia.org:
https://hg.mozilla.org/integration/autoland/rev/40ab96c6501c
Add localization comment to moreMenu.label r=mikedeboer
https://hg.mozilla.org/mozilla-central/rev/40ab96c6501c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Iteration: --- → 55.5 - May 15
See Also: → 1364741
You need to log in before you can comment on or make changes to this bug.