1364465 - Shaped-word caches in gfxFont instances should use fallible allocation

Status: RESOLVED FIXED

(Core :: Graphics: Text, enhancement)

Description

[Jonathan Kew [:jfkthame]]

The shaped-word cache attached to each gfxFont instance was originally intended to use fallible allocation when adding words, so that in the event of allocation failure we'd fail "softly" (missing text) rather than aborting. Hence, it explicitly checks for failure when trying to add a new entry to the cache:

https://dxr.mozilla.org/mozilla-central/rev/8a7d0b15595f9916123848ca906f29c62d4914c9/gfx/thebes/gfxFont.cpp#2592-2596

However, the hashtable it's using is now infallible by default, so to get the intended behavior we should add the 'fallible' parameter.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Make shaped-word caches in gfxFont instances use fallible allocation, for a less drastic failure mode in the event of allocation failure

Comment 2

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e9ae77f67a673945cc08b80b0cce36a66707d867
Bug 1364465 - Make shaped-word caches in gfxFont instances use fallible allocation, for a less drastic failure mode in the event of allocation failure. r=jrmuizel

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e9ae77f67a67