1364497 - Can not build seamonkey with msvc*140.dlls without ucrtbase.dll and api-ms-win-*.dlls

Status: RESOLVED WORKSFORME

(SeaMonkey :: Build Config, defect)

Description

[Bill Gianopoulos [:WG9s]]

It is not possible to build seamonkey with including the required msvc*140.dll files without also including ucrtbase.dll and all of the api-ms-win-*.dll file, the inclusion of those make my builds not start with a popup saying Unable to load XPCOM.

Removing this restriction permits me to build a 64 bit version which loads under windows 10 and windows 7.

Comment 1

[Bill Gianopoulos [:WG9s]]

Attachment: Permit defining WIN32_REDIST_DIR without defining WIN_UCRT_REDIST_DIR.

Comment 2

[Bill Gianopoulos [:WG9s]]

Like I said in my emails only including the msvc*140.dll files and not ucrtbase.dll and the api-ms-win*.dll files results in builds that launch and work under win10 and WIN7.  trying to include the other DLL files results in builds that do not.

Comment 3

[Bill Gianopoulos [:WG9s]]

Attachment: Permit defining WIN32_REDIST_DIR without defining WIN_UCRT_REDIST_DIR.wg9s3-cc.diff

Oops wrong patch.

Comment 4

[Bill Gianopoulos [:WG9s]]

This is all win-64 related your mileage may vary under win-32.

Comment 5

[Bill Gianopoulos [:WG9s]]

So the idea of this lame original change was there was no reason anyone would want to do this.  Well you are wrong.  I have a legitimate reason I want to do it.!

Comment 6

[Frank-Rainer Grahl (:frg)]

As stated the VS2015 and now VS2017 c++ runtime files need the ucrt. This one is not always available under Windows 7 x64 and for x86 not available separately under XP. Optional updates are only available for Vista and 7. A full build needs both or will not work on all systems.

>> I have a legitimate reason I want to do it.!

Maybe but you still need both in the build. 

Please check dependentlibs.list in your SeaMonkey install directory and see if you are missing any dlls. They need all to be in this directory.

Comment 7

[Ian Neal]

Comment on attachment 8867281 [details] [diff] [review]
Permit defining WIN32_REDIST_DIR without defining WIN_UCRT_REDIST_DIR.wg9s3-cc.diff

Redirecting review request to someone that builds regularly on windows

Comment 8

[Frank-Rainer Grahl (:frg)]

I just checked Fx 52 x64 and it included both the ucrt and VS2015 redist files. 

For x64 builds the redist files come from here (assuming VS2015 standard install):
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\redist\x64\Microsoft.VC140.CRT

The x64 ucrt can be found here (Windows 10.0.14393.795 toolkit):
C:\Program Files (x86)\Windows Kits\10\Redist\ucrt\DLLs\x64

Not all files in the directory are in dependentlibs.list but they end up in the distribution and are needed.

Comment 9

[Bill Gianopoulos [:WG9s]]

OK I chnaged my builds to use the redist files from those 2 places.  What I had tried previously, which did not work was using the ucrt dlls from the Operating system and the other redist files form VS2015.  Assuming those builds work on all of my windows instances, I will close this bug as INVALID.

Comment 10

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8867281 [details] [diff] [review]
Permit defining WIN32_REDIST_DIR without defining WIN_UCRT_REDIST_DIR.wg9s3-cc.diff

Clearing review. 

Just to make sure the the current setup also works with x64 I did build an x64 SeaMoney. The same vacpp and ucrt redist dlls as in Fx were included in the installer and ended up in the installation directory. The resulting build worked fine with Windows 7 x64.

Comment 11

[Frank-Rainer Grahl (:frg)]

Closing bug. If something still doesn't work please reopen or shoot me an email.