Closed Bug 1364516 Opened 3 years ago Closed 2 years ago

Move gCustomizeMode.setTab call out of updateTabLabelAndIcon

Categories

(Firefox :: Session Restore, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: dao, Assigned: dao)

Details

Attachments

(1 file)

While setTab does end up setting the label and icon, it also does completely different and more crucial things. This call really doesn't belong in updateTabLabelAndIcon.
Comment on attachment 8867294 [details]
Bug 1364516 - Move gCustomizeMode.setTab call out of updateTabLabelAndIcon.

https://reviewboard.mozilla.org/r/138830/#review142502

Agreed!
Attachment #8867294 - Flags: review?(mdeboer) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b96483ca2c27
Move gCustomizeMode.setTab call out of updateTabLabelAndIcon. r=mikedeboer
Backed out for failing mochitest browser/components/customizableui/test/browser_exit_background_customize_mode.js and eslint failure at SessionStore.jsm:3696:7 | 'win' is not defined:

https://hg.mozilla.org/integration/autoland/rev/3e02964068e932a2c5d9d474c4511a73c3819baf

Push with failures: https://hg.mozilla.org/integration/autoland/rev/b900cd113877e7a9ab8c283d936f79b2d8209721
Flags: needinfo?(dao+bmo)
Flags: needinfo?(dao+bmo)
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/25a7e2672c99
Move gCustomizeMode.setTab call out of updateTabLabelAndIcon. r=mikedeboer
https://hg.mozilla.org/mozilla-central/rev/25a7e2672c99
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.