Closed Bug 1364528 Opened 3 years ago Closed 3 years ago
Don't synchronously finalize native objects if an exception is pending
59 bytes, text/x-review-board-request
CycleCollectedJSRuntime synchronously finalizes native objects for non-incremental GCs. I believe this is mostly done because we use synchronous GCs in testing, and we want to check that things are actually destroyed by a certain point. However, bug 1362340 shows that we sometimes run a synch GC at weird points in the middle of JS calls, and that can end up setting an exception. That seems like it could be really bad, so I think we should just not sync finalize in that case. Hopefully it won't break any testing we do in the tree.
Comment on attachment 8867330 [details] Bug 1364528 - Don't synchronously finalize native objects if an exception is pending. https://reviewboard.mozilla.org/r/138846/#review142232
Attachment #8867330 - Flags: review?(bugs) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/a61ed4643a77 Don't synchronously finalize native objects if an exception is pending. r=smaug
You need to log in before you can comment on or make changes to this bug.