Closed Bug 1364546 Opened 7 years ago Closed 7 years ago

BookmarkTreeNode.children is not set for empty folders

Categories

(WebExtensions :: General, defect, P2)

52 Branch
defect

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: eveteska, Assigned: bsilverberg)

Details

(Whiteboard: [bookmarks] triaged)

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/603.2.4 (KHTML, like Gecko) Version/10.1.1 Safari/603.2.4

Steps to reproduce:

When enumerating bookmarks with the new WebExtension API, the BookmarkTreeNode.children variable is not set for empty folders. According to the documentation, it should be set for folders.


Actual results:

See above.


Expected results:

BookmarkTreeNode.children should be set to an empty array. This matches the documentation and Chrome's implementation.
Flags: needinfo?(bob.silverberg)
Hi Bob, if you have a good feeling for priority (based on your Bookmark API knowledge) can you set priority and mark as triaged.  If you want broader input, just remove your needinfo and we'll cover in group triage.
This sounds like a P2 to me, as it represents an incompatibility with Chrome (assuming the report is accurate), so I will set it thusly.
Assignee: nobody → bob.silverberg
Flags: needinfo?(bob.silverberg)
Priority: -- → P2
Whiteboard: [bookmarks] triaged
I confirmed that calling getTree in Firefox doesn't return a `children` property for empty folders, whereas it does in Chrome.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment on attachment 8870521 [details]
Bug 1364546 - Set the children property for BookmarkTreeNodes without children,

https://reviewboard.mozilla.org/r/141976/#review145676
Attachment #8870521 - Flags: review?(mixedpuppy) → review+
Thanks Shane!
Pushed by bsilverberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/86df61d9515c
Set the children property for BookmarkTreeNodes without children, r=mixedpuppy
https://hg.mozilla.org/mozilla-central/rev/86df61d9515c
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: