1364550 - File Input with `accept="image/jpeg"` does not accept .jpeg on macOS

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Daniel Duan]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.133 Safari/537.36

Steps to reproduce:

Create a file input that accepts jpegs

`<input type="file" accept="mime/jpeg">`



Actual results:

If you open the file selector, "all supported files" should be enabled by default but any file with .jpeg extension will greyed out. Only .jpg extension will be available.


Expected results:

.jpeg and .jpg extensions should both be available

Comment 1

[Marcos Caceres [:marcosc]]

Confirmed on MacOS also. 

Note that the steps are wrong, should be:


`<input type="file" accept="image/jpeg">`

But it's still broken.

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Jessica, mind taking a look?

Comment 3

[Marcos Caceres [:marcosc]]

Attachment: Example of it not enabling the right files

Comment 4

[Jessica Jong [:jessica] (inactive)]

I can reproduce this only on Mac not on Ubuntu.

HTMLInputElement::SetFilePickerFiltersFromAccept gets mimeInfo from mimeService, and mimeInfo is implemented for each OS.
For mac, it seems that we use the API `preferredExtensionForMIMEType`, so we only get one extension. Maybe we should use `extensionsForMIMEType` instead. Let me see if it works...


[1] http://searchfox.org/mozilla-central/rev/ae24a3c83d22e0e35aecfd9049c2b463ca7e045b/uriloader/exthandler/mac/nsOSHelperAppService.mm#504

Comment 5

[Jessica Jong [:jessica] (inactive)]

Attachment: patch, v1.

Comment 6

[Jessica Jong [:jessica] (inactive)]

Looking good on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d5ba4d07cbbac64cbd0d29008fe15d1ed9b277b7&group_state=expanded

Comment 7

[Jessica Jong [:jessica] (inactive)]

Comment on attachment 8868409 [details] [diff] [review]
patch, v1.

Hi baku, I've no idea who to ask for a review, maybe you can help? Thanks.

Comment 8

[Jessica Jong [:jessica] (inactive)]

Hmm, I can reproduce this on Windows 10 as well, and I can't find a suitable Windows API for this, we can only get one extension for MIME type from "HKEY_CLASSES_ROOT\MIME\Database\Content Type".

It looks like Chrome has two hard coded mapping lists that it adds to the OS extension list.


[1] https://cs.chromium.org/chromium/src/net/base/mime_util.cc?l=544

Comment 9

[Jessica Jong [:jessica] (inactive)]

Thanks baku.

Let's fix this for macOS first and file a separate bug to consider whether we should have a hard-coded list.

Comment 10

[Jessica Jong [:jessica] (inactive)]

Attachment: patch. r=baku

Added reviewer's name, carrying r+.

Comment 11

[Jessica Jong [:jessica] (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed6dbc237f8f60a8bf5cb0be458e4cbe17b5016f&group_state=expanded

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2acee92959cb
Get all extensions for a MIME type and not just the preferred one (macOS). r=baku

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2acee92959cb