1364552 - Delete unused code in ImageBitMapColorUtils.cpp

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, enhancement)

Description

[Christian Holler (:decoder)]

Static analysis barked on this function due to the use of unchecked multiplication flowing into a memcpy:

http://searchfox.org/mozilla-central/rev/cd8c561106d804e26bc09389f18f361846d005eb/dom/canvas/ImageBitmapColorUtils.cpp#419

Jeff mentioned that this was used by the code we disabled due to pwn2own and thinks it should just be deleted from the codebase. It isn't used anywhere except in a gtest. Filing this bug to make sure the deletion happens.

Comment 1

[Lorena Diaconescu]

Attachment: Bug 1364552 - Deleted unused RGB24Copy function, and corresponding macros and tests.

Review commit: https://reviewboard.mozilla.org/r/177342/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177342/

Comment 2

[Christian Holler (:decoder)]

Comment on attachment 8905546 [details]
Bug 1364552 - Deleted unused RGB24Copy function, and corresponding macros and tests.

Forwarding review, as I am not a peer for this part of the codebase.

Comment 3

[Lee Salzman [:lsalzman]]

Comment on attachment 8905546 [details]
Bug 1364552 - Deleted unused RGB24Copy function, and corresponding macros and tests.

https://reviewboard.mozilla.org/r/177342/#review184584

Comment 4

[Jonathan Watt [:jwatt]]

Lorena, do you plan to land this, or do you need someone to land this for you?

Comment 5

[Alex Gaynor [:Alex_Gaynor]]

Jonathan, can this be landed as is? :-)

Comment 6

[Jonathan Watt [:jwatt]]

Yes, it sure looks like it.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aaa8f66aac3b
Deleted unused RGB24Copy function, and corresponding macros and tests. r=lsalzman

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/aaa8f66aac3b