1364553 - implement signing on push for macosx opt taskcluster builds

Status: RESOLVED INVALID

(Firefox Build System :: Task Configuration, task)

Description

[Kim Moir [:kmoir] ET]

The existing buildbot builds are signed.  We have signing support in nightlies so we should be able to use these parts of the taskgraph.

Comment 1

[Kim Moir [:kmoir] ET]

Attachment: bug1364553date.patch

patch to renable cross compiled builds on date so I can test the taskgraph changes for mac signing

Comment 2

[Kim Moir [:kmoir] ET]

So I looked at the logs on this since Callek mentioned in the meeting that we don't need signed builds on push on mac in the tcmigration meeting today.  

https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-macosx64/1497400130/mozilla-inbound-macosx64-bm86-build1-build7254.txt.gz 

It looks like this build is signed
i.e.
17:29:21     INFO - [mozharness: 2017-06-14 00:29:21.015404Z] Running build step
....

17:30:11     INFO -  'MOZ_SIGNING_SERVERS': 'gpg:sha2signcode:sha2signcodestub:osslsigncode:signcode:mar:mar_sha384:jar:emevoucher:signing4.srv.releng.scl3.mozilla.com:9110,gpg:sha2signcode:sha2signcodestub:osslsigncode:signcode:mar:mar_sha384:jar:emevoucher:signing5.srv.releng.scl3.mozilla.com:9110,gpg:sha2signcode:sha2signcodestub:osslsigncode:signcode:mar:mar_sha384:jar:emevoucher:signing6.srv.releng.scl3.mozilla.com:9110,macapp:mac-v2-signing1.srv.releng.scl3.mozilla.com:9110,macapp:mac-v2-signing2.srv.releng.scl3.mozilla.com:9110,macapp:mac-v2-signing3.srv.releng.scl3.mozilla.com:9110,macapp:mac-v2-signing4.srv.releng.scl3.mozilla.com:9110,macapp:mac-v2-signing6.srv.releng.scl3.mozilla.com:9110,macapp:mac-v2-signing7.srv.releng.scl3.mozilla.com:9110',
17:30:11     INFO -  'MOZ_SIGN_CMD': '/tools/buildbot/bin/python /builds/slave/m-in-m64-000000000000000000000/build/tools/release/signing/signtool.py --cachedir /builds/slave/m-in-m64-000000000000000000000/build/signing_cache -t /builds/slave/m-in-m64-000000000000000000000/token -n /builds/slave/m-in-m64-000000000000000000000/nonce -c /builds/slave/m-in-m64-000000000000000000000/build/tools/release/signing/host.cert -H gpg:sha2signcode:sha2signcodestub:osslsigncode:signcode:mar:mar_sha384:jar:emevoucher:signing4.srv.releng.scl3.mozilla.com:9110 -H gpg:sha2signcode:sha2signcodestub:osslsigncode:signcode:mar:mar_sha384:jar:emevoucher:signing5.srv.releng.scl3.mozilla.com:9110 -H gpg:sha2signcode:sha2signcodestub:osslsigncode:signcode:mar:mar_sha384:jar:emevoucher:signing6.srv.releng.scl3.mozilla.com:9110 -H macapp:mac-v2-signing1.srv.releng.scl3.mozilla.com:9110 -H macapp:mac-v2-signing2.srv.releng.scl3.mozilla.com:9110 -H macapp:mac-v2-signing3.srv.releng.scl3.mozilla.com:9110 -H macapp:mac-v2-signing4.srv.releng.scl3.mozilla.com:9110 -H macapp:mac-v2-signing6.srv.releng.scl3.mozilla.com:9110 -H macapp:mac-v2-signing7.srv.releng.scl3.mozilla.com:9110',
17:3

Comment 3

[Kim Moir [:kmoir] ET]

So I talked to catlee at he mentioned that we know the buildbot builds are signed, we need to find out if the tc ones _need_ to be signed.  I looked at date and the tests are green but noticed that xpcshell for mac doesn't run on date, but this does run on m-c, so I'm going to turn enable that on date and see what happens.

https://treeherder.mozilla.org/#/jobs?repo=date&filter-searchStr=xpcshell&exclusion_profile=false&duplicate_jobs=visible

Comment 4

[Kim Moir [:kmoir] ET]

This is not required, catlee's push was green with the exception of some orange intermittents
https://treeherder.mozilla.org/#/jobs?repo=try&revision=26ce4f4ba353843c907dfa2e637e1a46a50d91d9